folder completion: suggest based on lhs of cursor, preserve rhs #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-baz
changed the title
patgmiller
approved these changes
May 30, 2025
Contributor
patgmiller
left a comment
patgmiller
left a comment
There was a problem hiding this comment.
@maximbaz LGTM! I let one extremely minor suggestion which is optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose your password store has folders "personal" and "work".
Press "Add credentials" in the popup, in the file name enter "github.com" (will be automatically done by #383), then press Home and try to autocomplete "personal" folder.
Before: autocomplete wouldn't show up
After: autocomplete shows up based on what there is on the left side of the cursor. So you can type "p" and it will exclude "work" and keep showing "personal". Pressing Enter prepends folder name, without overwriting "github.com".