Conversation
StarNet++ v2.5+ uses named flags (-i/-o/-s) instead of positional args. Also include the lib/ subdirectory in LD_LIBRARY_PATH so bundled OpenCV and ONNX Runtime shared objects resolve without a wrapper script. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
starnet_extractfor StarNet++ v2.5+, which switched from positional arguments to named flags (-i/-o/-s). Also adds<starnet_dir>/lib/toLD_LIBRARY_PATHsince v2.5 ships its shared libraries there.Current code passes positional args and exits 1 with
PARSE ERROR: Couldn't find match for argument.Test plan
pytest tests/passes locally — 674/682 tests pass; 8 pre-existing failures unrelated to this PR:test_orphan_master_removed(timing bug confirmed on upstreamfcb1243), 2xtest_scanner_orphans(Windows path-separator bug in_remove_orphans, only visible without -x), 5xtest_siril_runtime(no Siril binary on Windows dev machine)npm run checkclean fromui/— 0 errors; 3 pre-existing CSS warnings inplayground/themes(unrelated)Notes for the reviewer
The
-i/-o/-sflag style is the only documented interface in the v2.5 release notes. I have not tested against v2.4 or earlier with named flags, but the StarNet++ changelog notes the flags were added without removing positional support until v2.5 — so this should be safe either way.