Add first Requests HTTP client implementation #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is interesting... the advantage is I think this may be something better suited for your own application. I do not see this being widely useful |
|
Yes Requests is required by my project. But there is no much http framework in php (the other popular one I can think of is Guzzle). In the same time it avoids curl strong dependency on your project. |
Drop execute permissions on the php files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My project cannot have strong dependency with cUrl and because of that I created a new transport layer which use Requests project (http://requests.ryanmccue.info/), using cUrl or fsockopen according to what available.