-
Notifications
You must be signed in to change notification settings - Fork 0
[FEATURE] CRUD for knownTx entity #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Manual Testsℹ️ Remember to ask team members to perform manual tests and to assign |
d26d1e0
to
f83a827
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements CRUD operations for the knownTx entity by adding extensive filter functionality and comprehensive test coverage. The changes enable querying transactions by various criteria including status, block information, and notification state.
- Adds new filter conditions for BlockHeight, BlockHash, MerkleRoot, Status, and Notified fields
- Implements comprehensive test suite covering all new filter operations
- Enhances the query builder with new condition types for booleans and string enums
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
pkg/storage/provider_known_tx_enity_test.go | Adds comprehensive test coverage for all new filter conditions |
pkg/storage/internal/testabilities/utils.go | Provides test utility functions for random data generation |
pkg/storage/internal/testabilities/assertions_db_state.go | Adds new assertion methods for testing database state |
pkg/storage/crud/known_tx.go | Implements new filter methods for the KnownTxReader interface |
pkg/storage/crud/enum_condition.go | Creates new condition type for string-based enums |
pkg/storage/crud/bool_condition.go | Creates new condition type for boolean fields |
pkg/services/services_types.go | Adds ScriptHasher interface definition |
pkg/internal/testabilities/testservices/fixture_arc.go | Adds mock method for testing block height scenarios |
pkg/internal/storage/repo/known_tx.go | Implements actual database condition logic |
pkg/internal/storage/repo/gen_cmp_condition.go | Adds specialized boolean comparison handling |
pkg/entity/known_tx.go | Extends specification with new filterable fields |
pkg/entity/comparable.go | Adds string conversion and operator string representation |
Comments suppressed due to low confidence (1)
pkg/storage/provider_known_tx_enity_test.go:1
- The filename contains a typo: 'enity' should be 'entity'.
package storage_test
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: augustyn chmiel <[email protected]>
4b8ffe3
to
be3a9ad
Compare
92f1992
to
7de3486
Compare
|
Description of Changes
Provide a brief description of the changes you've made.
Linked Issues / Tickets
Reference any related issues or tickets, e.g. "Closes #123".
Testing Procedure
Describe the tests you've added or any testing steps you've taken.
Checklist: