Skip to content

Conversation

ac4ch
Copy link
Collaborator

@ac4ch ac4ch commented Sep 25, 2025

Description of Changes

Provide a brief description of the changes you've made.

Linked Issues / Tickets

Reference any related issues or tickets, e.g. "Closes #123".

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run the linter

@ac4ch ac4ch added this to the Wallet Services milestone Sep 25, 2025
@ac4ch ac4ch self-assigned this Sep 25, 2025
@ac4ch ac4ch added the feature Any new significant addition label Sep 25, 2025
Copy link
Contributor

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

Copy link
Contributor

github-actions bot commented Sep 25, 2025

Manual Tests

💚 Manual testing by @cain4chain resulted in success.

@ac4ch ac4ch linked an issue Sep 25, 2025 that may be closed by this pull request
@ac4ch ac4ch force-pushed the feat/implement_getFiatExchangeRate_on_WalletServices branch from 160290f to 8166b99 Compare September 25, 2025 07:18
@cain4chain cain4chain added the tested PR was tested by a team member label Sep 25, 2025
@ac4ch ac4ch force-pushed the feat/implement_getFiatExchangeRate_on_WalletServices branch from 8166b99 to 3f132b5 Compare September 25, 2025 09:53
@dorzepowski dorzepowski requested a review from Copilot September 25, 2025 13:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the getFiatExchangeRate method on WalletServices to support fiat currency exchange rate conversion functionality. The implementation allows users to convert between different fiat currencies using configurable exchange rates.

Key changes:

  • Replaced panic placeholder with actual implementation of FiatExchangeRate method
  • Added comprehensive unit tests covering various conversion scenarios and edge cases
  • Created documentation and example code demonstrating the new functionality

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pkg/services/services.go Implements the FiatExchangeRate method with currency conversion logic
pkg/services/services_fiat_exchange_test.go Adds comprehensive test coverage for the new method
examples/services_examples/fiat_exhange_rate/fiat_exchange_rate.go Provides example implementation demonstrating usage
examples/services_examples/fiat_exhange_rate/fiat_exchange_rate.md Documentation explaining the feature and usage
examples/services_examples/nlock_time_is_final/nlock_time_is_final.go Removes inline documentation comment
examples/services_examples/nlock_time_is_final/nlock_time_is_final.md Adds separate documentation file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ac4ch ac4ch force-pushed the feat/implement_getFiatExchangeRate_on_WalletServices branch from 428c120 to 03e9c78 Compare September 26, 2025 05:02
@ac4ch ac4ch requested a review from dorzepowski September 26, 2025 17:10
@ac4ch ac4ch force-pushed the feat/implement_getFiatExchangeRate_on_WalletServices branch from 03e9c78 to 2b0c62f Compare September 29, 2025 04:36
@ac4ch ac4ch enabled auto-merge (squash) September 29, 2025 04:37
Copy link

@ac4ch ac4ch merged commit a7cadad into main Sep 29, 2025
10 checks passed
@ac4ch ac4ch deleted the feat/implement_getFiatExchangeRate_on_WalletServices branch September 29, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] implement getFiatExchangeRate on WalletServices [FEATURE] internalizeAction MVP on sql storage
5 participants