Skip to content

feat : require video url to request listing#173

Merged
TChukwuleta merged 4 commits intobtcpayserver:masterfrom
teamssUTXO:master
Mar 18, 2026
Merged

feat : require video url to request listing#173
TChukwuleta merged 4 commits intobtcpayserver:masterfrom
teamssUTXO:master

Conversation

@teamssUTXO
Copy link
Copy Markdown
Contributor

Related to this issue : #160 .

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 18, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'auto_resolve_threads'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: df585eb8-3567-42d4-b093-b03a6ecc998c

📥 Commits

Reviewing files that changed from the base of the PR and between 25b51a3 and 7a12a07.

📒 Files selected for processing (1)
  • PluginBuilder.Tests/PluginTests/PluginRequestListingUITest.cs
🚧 Files skipped from review as they are similar to previous changes (1)
  • PluginBuilder.Tests/PluginTests/PluginRequestListingUITest.cs

Walkthrough

Adds VideoUrl to the set of required listing prerequisites checked in PluginController (docsMissing / ListingRequirementsMet logic). Updates RequestListing view text to include "Video URL". Adds overflow-x: hidden rules in Build view HeaderScripts. Updates a UI test to populate the VideoUrl field before submitting the plugin request form.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • feat: add plugins video #150: Adds the VideoUrl property and related validation/propagation logic that aligns with this PR's prerequisite checks.

Suggested reviewers

  • thgO-O
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding VideoUrl as a required field for requesting a listing.
Description check ✅ Passed The description references issue #160 and is related to the changeset, though minimal in detail.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
PluginBuilder/Views/Plugin/Build.cshtml (1)

176-178: Unrelated CSS change - consider separating into a different PR.

This overflow-x: hidden rule is unrelated to the PR objective of requiring a video URL for listing requests. Adding global overflow hiding can mask underlying layout issues rather than addressing them properly.

If there's a specific horizontal scrollbar problem on this page, consider investigating the root cause (e.g., an element overflowing its container) rather than hiding it globally on body and html.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@PluginBuilder/Views/Plugin/Build.cshtml` around lines 176 - 178, The global
CSS rule "body, html { overflow-x: hidden; }" in Build.cshtml is unrelated to
the video-URL validation PR; remove this change from the current diff and either
revert to the previous state or move the rule into a separate styling change/PR
after investigating the real cause of horizontal overflow (e.g., fix the
overflowing element), referencing the selector "body, html" and the rule
"overflow-x: hidden" so reviewers can locate and separate the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@PluginBuilder/Views/Plugin/RequestListing.cshtml`:
- Line 59: The UI text in RequestListing.cshtml omits the required "Description"
field checked by PluginController.ListingRequirementsMet; update the sentence
(in RequestListing.cshtml) to list all required fields including "Description"
so the UI matches the controller validation (ensure the displayed text mentions
Logo, Documentation URL, Video URL, Git Repository and Description).
- Line 59: In the RequestListing.cshtml template update the displayed sentence
literal "Your plugin must include Logo, Documentation URL, Video URL and Git
Repository. Click" to add a comma after "Video URL" so the list reads "Logo,
Documentation URL, Video URL, and Git Repository" (adjust the surrounding text
accordingly) to ensure consistent punctuation.

---

Nitpick comments:
In `@PluginBuilder/Views/Plugin/Build.cshtml`:
- Around line 176-178: The global CSS rule "body, html { overflow-x: hidden; }"
in Build.cshtml is unrelated to the video-URL validation PR; remove this change
from the current diff and either revert to the previous state or move the rule
into a separate styling change/PR after investigating the real cause of
horizontal overflow (e.g., fix the overflowing element), referencing the
selector "body, html" and the rule "overflow-x: hidden" so reviewers can locate
and separate the change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e6b31e67-fd5f-4b9a-8c61-14d725cd0523

📥 Commits

Reviewing files that changed from the base of the PR and between b218b9f and 24df634.

📒 Files selected for processing (3)
  • PluginBuilder/Controllers/PluginController.cs
  • PluginBuilder/Views/Plugin/Build.cshtml
  • PluginBuilder/Views/Plugin/RequestListing.cshtml

@TChukwuleta
Copy link
Copy Markdown
Collaborator

Nice one @teamssUTXO

ermm.. LGTM

Just wondering what the change in Build.cshtml is for?..
(I haven't ran the code tho.)

@teamssUTXO
Copy link
Copy Markdown
Contributor Author

Hi @TChukwuleta , here is the preview of what I change in the Build.cshtml file :

Votre texte de paragraphe

I'm fixing playwright tests.

@TChukwuleta TChukwuleta merged commit 40a65e7 into btcpayserver:master Mar 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants