feat : require video url to request listing#173
feat : require video url to request listing#173TChukwuleta merged 4 commits intobtcpayserver:masterfrom
Conversation
|
Note
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title accurately summarizes the main change: adding VideoUrl as a required field for requesting a listing. |
| Description check | ✅ Passed | The description references issue #160 and is related to the changeset, though minimal in detail. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
📝 Coding Plan
- Generate coding plan for human review comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
PluginBuilder/Views/Plugin/Build.cshtml (1)
176-178: Unrelated CSS change - consider separating into a different PR.This
overflow-x: hiddenrule is unrelated to the PR objective of requiring a video URL for listing requests. Adding global overflow hiding can mask underlying layout issues rather than addressing them properly.If there's a specific horizontal scrollbar problem on this page, consider investigating the root cause (e.g., an element overflowing its container) rather than hiding it globally on
bodyandhtml.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@PluginBuilder/Views/Plugin/Build.cshtml` around lines 176 - 178, The global CSS rule "body, html { overflow-x: hidden; }" in Build.cshtml is unrelated to the video-URL validation PR; remove this change from the current diff and either revert to the previous state or move the rule into a separate styling change/PR after investigating the real cause of horizontal overflow (e.g., fix the overflowing element), referencing the selector "body, html" and the rule "overflow-x: hidden" so reviewers can locate and separate the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@PluginBuilder/Views/Plugin/RequestListing.cshtml`:
- Line 59: The UI text in RequestListing.cshtml omits the required "Description"
field checked by PluginController.ListingRequirementsMet; update the sentence
(in RequestListing.cshtml) to list all required fields including "Description"
so the UI matches the controller validation (ensure the displayed text mentions
Logo, Documentation URL, Video URL, Git Repository and Description).
- Line 59: In the RequestListing.cshtml template update the displayed sentence
literal "Your plugin must include Logo, Documentation URL, Video URL and Git
Repository. Click" to add a comma after "Video URL" so the list reads "Logo,
Documentation URL, Video URL, and Git Repository" (adjust the surrounding text
accordingly) to ensure consistent punctuation.
---
Nitpick comments:
In `@PluginBuilder/Views/Plugin/Build.cshtml`:
- Around line 176-178: The global CSS rule "body, html { overflow-x: hidden; }"
in Build.cshtml is unrelated to the video-URL validation PR; remove this change
from the current diff and either revert to the previous state or move the rule
into a separate styling change/PR after investigating the real cause of
horizontal overflow (e.g., fix the overflowing element), referencing the
selector "body, html" and the rule "overflow-x: hidden" so reviewers can locate
and separate the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e6b31e67-fd5f-4b9a-8c61-14d725cd0523
📒 Files selected for processing (3)
PluginBuilder/Controllers/PluginController.csPluginBuilder/Views/Plugin/Build.cshtmlPluginBuilder/Views/Plugin/RequestListing.cshtml
|
Nice one @teamssUTXO ermm.. LGTM Just wondering what the change in Build.cshtml is for?.. |
|
Hi @TChukwuleta , here is the preview of what I change in the Build.cshtml file : I'm fixing playwright tests. |

Related to this issue : #160 .