Get smoke tests running again #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the Makefrag-provided ID to match the default configuration. This gets failing smoke tests (csr.S and id.S) to pass. Signed-off-by: Schuyler Eldridge <[email protected]>
This uses the standard calling convention of x10, etc. for running the debug test. Signed-off-by: Schuyler Eldridge <[email protected]>
This correctly determine what is not a bad request when in user mode. Signed-off-by: Schuyler Eldridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #49.
This fixes a bug in how a bad request was determined by the arbiter.
Additionally, the ID string is cleaned up to match the configuration specified in the README.