Skip to content

e2e test scenario improvements #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
Merged

e2e test scenario improvements #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1145dff
Remove unnecessary steps
Nov 19, 2025
f83a8d9
Wait for named spans where feasible
Nov 19, 2025
923e205
Use parent span step directly
Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions features/full_tests/correlation.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@ Feature: Manual creation of spans

Scenario: Errors notified within a span include the correlation data
Given I run "CorrelatedErrorScenario"
And I wait to receive a trace
And I wait to receive a span named "CorrelatedError Span"
And I wait to receive an error

* a span name equals "CorrelatedError Span"
* a span field "kind" equals 1
* a span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
* a span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
* a span field "startTimeUnixNano" matches the regex "^[0-9]+$"
* a span field "endTimeUnixNano" matches the regex "^[0-9]+$"

Expand Down
3 changes: 1 addition & 2 deletions features/full_tests/frame_metrics.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ Scenario: Slow & Frozen Frames are reported
* a span name equals "FrozenFrame"

# The FrozenFrame span should be a child of Slow Animation
* the "Slow Animation" span field "spanId" is stored as the value "slow_animation_spanId"
* the "FrozenFrame" span field "parentSpanId" equals the stored value "slow_animation_spanId"
* a span named "FrozenFrame" has a parent named "Slow Animation"

* the "Slow Animation" span integer attribute "bugsnag.rendering.slow_frames" is greater than 0
* the "Slow Animation" span integer attribute "bugsnag.rendering.frozen_frames" is greater than 0
Expand Down
3 changes: 1 addition & 2 deletions features/full_tests/instrumentation.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,5 +268,4 @@ Feature: Automatic creation of spans
| bugsnag.span.category | stringValue | view_load |
| bugsnag.view.type | stringValue | compose |
| bugsnag.view.name | stringValue | Composable |
* the "[ViewLoad/Activity]ComposeViewLoadActivity" span field "spanId" is stored as the value "activity_load_span_id"
* the "[ViewLoad/Compose]Composable" span field "parentSpanId" equals the stored value "activity_load_span_id"
* a span named "[ViewLoad/Compose]Composable" has a parent named "[ViewLoad/Activity]ComposeViewLoadActivity"
2 changes: 0 additions & 2 deletions features/full_tests/manual_spans.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ Feature: Manual creation of spans

* a span name equals "ManualSpanScenario"
* a span field "kind" equals 1
* a span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
* a span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
* a span field "startTimeUnixNano" matches the regex "^[0-9]+$"
* a span field "endTimeUnixNano" matches the regex "^[0-9]+$"
* a span string attribute "net.host.connection.type" exists
Expand Down
22 changes: 8 additions & 14 deletions features/full_tests/nested_spans.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,25 +76,19 @@ Feature: Nested spans
| bugsnag.span.category | stringValue | custom |
| bugsnag.span.first_class | boolValue | true |

# Check span parentage (nested under NestedSpansActivity)
* the "[ViewLoadPhase/ActivityStart]NestedSpansActivity" span field "spanId" is stored as the value "activity_start_span_id"
* the "[ViewLoadPhase/ActivityResume]NestedSpansActivity" span field "spanId" is stored as the value "activity_resume_span_id"
* the "[ViewLoad/Activity]NestedSpansActivity" span field "spanId" is stored as the value "view_load_span_id"
* the "CustomRoot" span field "spanId" is stored as the value "custom_root_span_id"

# ViewLoadPhase phase spans (Create, Start, Resume) should be nested under ViewLoad
* the "[ViewLoadPhase/ActivityCreate]NestedSpansActivity" span field "parentSpanId" equals the stored value "view_load_span_id"
* the "[ViewLoadPhase/ActivityStart]NestedSpansActivity" span field "parentSpanId" equals the stored value "view_load_span_id"
* the "[ViewLoadPhase/ActivityResume]NestedSpansActivity" span field "parentSpanId" equals the stored value "view_load_span_id"
* a span named "[ViewLoadPhase/ActivityCreate]NestedSpansActivity" has a parent named "[ViewLoad/Activity]NestedSpansActivity"
* a span named "[ViewLoadPhase/ActivityStart]NestedSpansActivity" has a parent named "[ViewLoad/Activity]NestedSpansActivity"
* a span named "[ViewLoadPhase/ActivityResume]NestedSpansActivity" has a parent named "[ViewLoad/Activity]NestedSpansActivity"

# FirstFragment should be nested under ViewLoadPhase/Start
* the "[ViewLoad/Fragment]FirstFragment" span field "parentSpanId" equals the stored value "activity_start_span_id"
* a span named "[ViewLoad/Fragment]FirstFragment" has a parent named "[ViewLoadPhase/ActivityStart]NestedSpansActivity"

# CustomRoot should be nested under ViewLoadPhase/Resume
* the "CustomRoot" span field "parentSpanId" equals the stored value "activity_resume_span_id"
* a span named "CustomRoot" has a parent named "[ViewLoadPhase/ActivityResume]NestedSpansActivity"

# Remaining spans (SecondFragment, DoStuff, LoadData) should be nested under CustomRoot
* the "[ViewLoad/Fragment]SecondFragment" span field "parentSpanId" equals the stored value "custom_root_span_id"
* the "DoStuff" span field "parentSpanId" equals the stored value "custom_root_span_id"
* the "LoadData" span field "parentSpanId" equals the stored value "custom_root_span_id"
* a span named "[ViewLoad/Fragment]SecondFragment" has a parent named "CustomRoot"
* a span named "DoStuff" has a parent named "CustomRoot"
* a span named "LoadData" has a parent named "CustomRoot"

9 changes: 1 addition & 8 deletions features/full_tests/okhttp_spans.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@ Feature: OkHttp EventListener

Scenario: NetworkRequest spans are logged for requests
Given I run "OkhttpSpanScenario"
And I wait to receive a trace
* a span name equals "[HTTP/GET]"
* a span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
* a span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
And I wait to receive a span named "[HTTP/GET]"
* a span field "kind" equals 3
* a span field "startTimeUnixNano" matches the regex "^[0-9]+$"
* a span field "endTimeUnixNano" matches the regex "^[0-9]+$"
Expand All @@ -30,8 +27,6 @@ Feature: OkHttp EventListener
Then the trace "Content-Type" header equals "application/json"
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
* every span field "name" equals "[HTTP/GET]"
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
* a span string attribute "http.url" equals "https://www.google.com/"
Expand All @@ -43,8 +38,6 @@ Feature: OkHttp EventListener
Then the trace "Content-Type" header equals "application/json"
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
* every span field "name" equals "[HTTP/GET]"
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
* a span string attribute "http.url" equals "https://www.google.com/"
Expand Down
4 changes: 3 additions & 1 deletion features/full_tests/plugins.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ Feature: Plugins
Scenario: Plugins can automatically update spans
Given I run "PluginScenario"
And I wait to receive a sampling request
And I wait to receive a trace
And I wait to receive a span named "Span 1"
And I wait to receive a span named "Span 2"
And I wait to receive a span named "Span 3"

Then a span named "Span 1" contains the attributes:
| attribute | type | value |
Expand Down
1 change: 0 additions & 1 deletion features/full_tests/server_response.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,3 @@ Feature: Server responses
And I wait to receive 1 trace
# 400 - Payload rejected, no retry
Then a span name equals "span 1"
And I discard the oldest trace
Loading