Skip to content

Conversation

@gingerbenw
Copy link
Member

@gingerbenw gingerbenw commented Nov 17, 2025

Goal

This PR adds end-to-end tests for system metrics in the React Native integration. The changes enable CPU, memory, and rendering metrics collection and provide test infrastructure to verify these metrics are properly captured.

Changeset

  • Added a new test step to validate span attributes in traces
  • Updated iOS configuration to enable individual system metrics (CPU, memory, rendering)
  • Refactored Docker Compose environment variable placement

@gingerbenw gingerbenw requested a review from Copilot November 17, 2025 12:27

This comment was marked as resolved.

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Browser bundle size

NPM build

Package
Before 235.35 kB
After 235.35 kB
± No change

CDN build

Unminified Minfied Minified + gzipped
Before 119.43 kB 46.18 kB 13.29 kB
After 119.43 kB 46.18 kB 13.29 kB
± No change No change No change

Code coverage

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
84.94%(+0%) 63.87%(+0%) 75.79%(+0%) 81.75%(+0%)

Generated against 4e98ca8 on 18 November 2025 at 15:31:20 UTC

@gingerbenw gingerbenw changed the title test: ✅ add end to end tests for system metrics Add end to end tests for system metrics Nov 17, 2025
@gingerbenw gingerbenw force-pushed the PLAT-14037/system-metrics-cocoa branch from 870311c to 6ad0174 Compare November 17, 2025 14:22
@gingerbenw gingerbenw requested a review from Copilot November 17, 2025 14:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gingerbenw gingerbenw force-pushed the PLAT-14037/system-metrics-cocoa branch 6 times, most recently from 8c48ab3 to 73b8021 Compare November 18, 2025 14:13
@gingerbenw gingerbenw force-pushed the PLAT-14037/system-metrics-cocoa branch from 73b8021 to 4e98ca8 Compare November 18, 2025 15:26
@gingerbenw gingerbenw requested a review from a team November 18, 2025 16:54
@gingerbenw gingerbenw marked this pull request as ready for review November 18, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants