Configurable timeout for native app start plugins #749
+28
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The current 500ms view load span timeout for native app starts sometimes isn’t long enough, particularly in debug builds where the React Native layer can take a long time to initialize.
This PR ups the default timeout to 5ms, and allows users to configure their own timeout via the
ReactNativeAppStartPluginconstructorDesign
On Android, the timeout is an integer in milliseconds, while on Objective-C the timeout is an
NSTimeIntervalin seconds.Android
iOS
Testing
Tested manually