Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust): rename cloud module to orchestrator #8758

Merged
merged 2 commits into from
Jan 20, 2025
Merged

refactor(rust): rename cloud module to orchestrator #8758

merged 2 commits into from
Jan 20, 2025

Conversation

adrianbenavides
Copy link
Member

@adrianbenavides adrianbenavides commented Jan 17, 2025 •
edited
Loading

  • Minor cleanup of the old "cloud" module of the ockam_command crate
  • Revert command features, as this could interfere with the next release. I'm also working on a different approach that won't use cargo features

@adrianbenavides adrianbenavides force-pushed the adrian/custom-branding-continued branch from 9fcd40a to 1382e4e Compare January 17, 2025 15:03
@adrianbenavides adrianbenavides force-pushed the adrian/custom-branding-continued branch from 1382e4e to b80f016 Compare January 20, 2025 14:26
@adrianbenavides adrianbenavides force-pushed the adrian/custom-branding-continued branch from b80f016 to 6dc2087 Compare January 20, 2025 14:28
@adrianbenavides adrianbenavides marked this pull request as ready for review January 20, 2025 14:34
@adrianbenavides adrianbenavides requested a review from a team as a code owner January 20, 2025 14:34
etorreborre
etorreborre approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@etorreborre etorreborre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍡

@adrianbenavides adrianbenavides added this pull request to the merge queue Jan 20, 2025
Merged via the queue into develop with commit 20a9025 Jan 20, 2025
30 checks passed
@adrianbenavides adrianbenavides deleted the adrian/custom-branding-continued branch January 20, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etorreborre etorreborre etorreborre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianbenavides @etorreborre