Skip to content

[email protected] #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Aug 22, 2025
Merged

[email protected] #32

merged 26 commits into from
Aug 22, 2025

Conversation

StephenHodgson
Copy link
Member

@StephenHodgson StephenHodgson commented Aug 15, 2025

  • fix partial version matching (again)
  • fix unity hub 3.14 support
    • someone thought it was a good idea to change the cli output which used to separate the editor version and installed path with a ,

- fix partial version matching (again)
@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 14:32
@StephenHodgson StephenHodgson requested a review from a team as a code owner August 15, 2025 14:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses partial version matching issues in the unity-setup action and bumps the version to v1.2.5. The primary goal is to fix the sorting order for fallback version matching to prioritize higher versions over lower ones.

Key changes:

  • Fixed version fallback logic to sort in descending order (highest first) instead of ascending
  • Added validation logic in the build workflow to verify Unity version compatibility
  • Updated package dependencies to newer versions

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.

File Description
src/unity-version.ts Fixed sorting order for version fallback and improved code formatting
package.json Bumped version to 1.2.5 and updated dependencies
.github/workflows/build.yml Added Unity version validation logic to verify compatibility
.github/workflows/build-options.json Added new Unity version "6000.1" to test matrix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@buildalon buildalon deleted a comment from Copilot AI Aug 16, 2025
@StephenHodgson StephenHodgson merged commit 3654f82 into main Aug 22, 2025
29 checks passed
@StephenHodgson StephenHodgson deleted the development branch August 22, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant