-
Notifications
You must be signed in to change notification settings - Fork 1
[email protected] #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- fix partial version matching (again)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses partial version matching issues in the unity-setup action and bumps the version to v1.2.5. The primary goal is to fix the sorting order for fallback version matching to prioritize higher versions over lower ones.
Key changes:
- Fixed version fallback logic to sort in descending order (highest first) instead of ascending
- Added validation logic in the build workflow to verify Unity version compatibility
- Updated package dependencies to newer versions
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/unity-version.ts | Fixed sorting order for version fallback and improved code formatting |
package.json | Bumped version to 1.2.5 and updated dependencies |
.github/workflows/build.yml | Added Unity version validation logic to verify compatibility |
.github/workflows/build-options.json | Added new Unity version "6000.1" to test matrix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
added additional tests
,