fix: remove CSP nonce from style-src to unblock reagraph canvas#425
Merged
fix: remove CSP nonce from style-src to unblock reagraph canvas#425
Conversation
📸 Screenshot Drift CheckThis PR modifies UI source files. Please verify whether the README screenshots need refreshing:
Changed UI filesSee This comment is posted automatically and can be dismissed if no visual changes occurred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
style-src 'self' 'nonce-X'withstyle-src 'self' 'unsafe-inline',style-src-elem 'self' 'unsafe-inline', andstyle-src-attr 'unsafe-inline'to support reagraph's runtime<style>injectionfitNodesInViewretries from 2 to 4 (800ms, 2500ms, 5000ms, 8000ms) withanimated: falsefor more reliable canvas sizingCloses #414. Supersedes #415 — thanks @Brixyy for identifying the issue.
Risk Level
Low — CSP change is intentional relaxation for style-src only; script-src nonce remains strict.
Tests
pnpm typecheck— passespnpm test— 710/710 passing (CSP tests updated)Contribution Checklist
Notes
CSP Level 3 spec: when a nonce is present in
style-src,unsafe-inlineis ignored. Since reagraph injects<style>without a nonce, the only option is to drop the nonce from style directives.