chore(design-system): re-sync @uploads/ui to Claude Design - #665
Conversation
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Re-sync of the 14-component library to the "Uploads" Claude Design project. All 14 verified-by-upload against the project's `_ds_sync.json` anchor — no component sources changed, so nothing needed re-grading. Three sync inputs corrected along the way: - `Progress` and `Select` now take `cardMode: "column"`. A newer converter measures grid cells differently and flagged both `[GRID_OVERFLOW]`; NOTES.md had recorded them as fitting the default width. Their preview sheets were re-checked after the fix and still grade good. - `conventions.md` now lists `Button`'s `solid` variant and `icon` prop. Both ship real CSS and JSDoc, but the header predated them — the design agent would never have learned `solid` exists. - NOTES.md: the worktree build recipe said `npx tsup`, which emits no declarations (`dts: false` in tsup.config.ts). Corrected to `npm run build`, plus a note that header drift is usually additive rather than renames. Validate exits clean with no warnings; render check 14/14.
The earlier sync in this branch was built from a worktree branched at #663, one commit before #664 landed. It rebuilt and re-uploaded the pre-#664 stylesheet about an hour after that fix merged, restoring the exact `--ul-progress-fill` declaration #664 removed. The Claude Design agent kept reporting the finding against the uploaded CSS and was correct to. Rebased onto `origin/main` (9f0de53), rebuilt, and re-uploaded. The shipped bundle now has zero `--ul-*` custom-property declarations; the token count drops 32 -> 31. Progress still renders three distinct bands through `currentColor` (sheets re-checked, grades held), render check 14/14, validate clean with no warnings. Adds a Re-sync risk note: a sync uploads whatever the tree builds, so a stale base silently reverts merged design-system fixes and the anchor diff cannot catch it — the bundle genuinely changed and reads as a legitimate update. Fetch and check `origin/main` before building, then grep the built bundle for whatever the most recent DS fix removed.
41feeb1 to
bb5ff59
Compare
1 participant
Re-sync of
@uploads/uito the Uploads Claude Design project(
8ccd3608),rebased onto #664.
State after the fix
--ul-*custom-property declarations; token countdrops 32 → 31 (
--ul-progress-fillgone).Progressstill renders three distinct fill bands throughcurrentColor—preview sheets re-checked, grades held.
_ds_sync.json.Sync-input changes
ProgressandSelectnow takecardMode: "column". A newer convertermeasures grid cells differently and flagged both
[GRID_OVERFLOW]; NOTES.md hadrecorded them as fitting the default card width, so the warn read as new.
conventions.mddocumentsButton'ssolidvariant andiconprop. Bothship real CSS (
ul-btn--solid) and JSDoc, but the header predated them. Sincethat header is inlined into the design agent's system prompt, the agent would
never have learned
solidexists.NOTES.md — two corrections and a new risk. The worktree build recipe said
npx tsup, which emits no declarations (dts: false); the.d.tsfiles comefrom the
tsc --emitDeclarationOnlyhalf of the build script. Added aRe-sync risks entry for the stale-base hazard above: a sync uploads whatever
the tree builds, so a stale base silently reverts merged DS fixes and the anchor
diff cannot catch it — the bundle genuinely changed and reads as a legitimate
update. Fetch and check
origin/mainbefore building, then grep the builtbundle for whatever the most recent DS fix removed.
No components added or removed.