Skip to content

feat(web): redesign the workspace GitHub comment settings page - #666

Merged
Zach Dunn (zachdunn) merged 1 commit into
mainfrom
claude/design-system-settings-cleanup-1beedd
Aug 14, 2026
Merged

feat(web): redesign the workspace GitHub comment settings page#666
Zach Dunn (zachdunn) merged 1 commit into
mainfrom
claude/design-system-settings-cleanup-1beedd

Conversation

@zachdunn

@zachdunn Zach Dunn (zachdunn) commented Aug 14, 2026

Copy link
Copy Markdown
Member

Before / after

Before After
GitHub comment settings, before the redesign GitHub comment settings, after the redesign

Captured against the local dev server with the admin-gated section force-revealed; the Install GitHub App callout is conditional (shown only when the App isn't installed) so it doesn't appear in this unauthenticated capture.

Ports the Claude Design workspace-settings redesign onto the GitHub-comment settings tab (/account/workspaces/<name>/settings). The app shell, sidebar, and rail already come from WorkspaceLayout, so this touches only the content section and the preview rail slot.

What changed

  • Copy — heading GitHub commentGitHub; new one-line intro; reworded row descriptions; noteNote (optional), ingest github attachmentsImport GitHub attachments, link to file pagesLink items to file pages.
  • Style — row labels moved from uppercase-mono to sentence-case sans (600/13px); segmented control uses sans; roomier hairline rows. Mock values translated to the app's design tokens (kept DS --radius-sm/md over the mock's 2px).
  • Install GitHub App callout — shown only when the workspace has no App installed (getGithubInstalled, fail-open, same call the rail uses).
  • Toggles — Metadata captions / Link items / Import became role="switch" toggles. Per product decision they write an explicit boolean and drop the null/"auto" tri-state: a previously-null row is painted at its effective default and pinned to that boolean on the next save, so behaviour is unchanged.
  • Floating save bar — pinned bottom-center with Reset + Save changes, revealed only when dirty, with a transient "Saved." flash and an inline error on failure. Replaces the old inline Save button.
  • Preview rail head — now reuses the rail's own preview —— divider (matching usage / tip below it) with the "unsaved edits" chip.

⚠️ Save-bar consistency note

The floating save bar is currently a one-off. The sibling Storage tab in this same Settings view (settings/storage.astro) and the admin OAuth editor (admin/oauth/[clientId].astro) still use inline Save buttons — the pattern this page had before. If we want the Settings tabs to feel uniform, a follow-up should migrate those to the same floating bar (happy to do it in a separate PR).

Verification

  • astro check + tsc: 0 errors, 0 warnings
  • Web tests: 611 passed
  • Lint/prettier clean
  • Rendered in the real app cascade — toggle on-state uses the accent (28% bg + accent border), labels compute to 600 13px Geist Variable, save bar renders with the solid-accent button

Web-only change (@uploads/web is changeset-ignored) — no changeset.

Port the Claude Design workspace-settings redesign onto the GitHub
comment tab (issue #365):

- sentence-case sans row labels; roomier hairline rows
- metadata / link / import rows become on/off toggles, dropping the
  auto/on/off tri-state; the workspace value is the effective default,
  so a null row is painted at its default and pinned to an explicit
  boolean on the next save (behaviour unchanged)
- floating save bar (Reset + Save changes) replaces the inline button
- Install GitHub App callout, shown only when the App is not installed
- preview rail head reuses the rail's own section divider

Web-only (@uploads/web is changeset-ignored), so no changeset.
@changeset-bot

changeset-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d08fb69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (2)
  • coderabbit:review
  • review
🚫 Excluded labels (none allowed) (1)
  • wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0497d462-a491-4535-ad10-8b558eecb30b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
uploads-web d08fb69 Commit Preview URL

Branch Preview URL
Aug 14 2026, 03:05 PM

@zachdunn
Zach Dunn (zachdunn) merged commit aa1cbcb into main Aug 14, 2026
4 checks passed
@zachdunn
Zach Dunn (zachdunn) deleted the claude/design-system-settings-cleanup-1beedd branch August 14, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant