feat(web): redesign the workspace GitHub comment settings page - #666
Conversation
Port the Claude Design workspace-settings redesign onto the GitHub comment tab (issue #365): - sentence-case sans row labels; roomier hairline rows - metadata / link / import rows become on/off toggles, dropping the auto/on/off tri-state; the workspace value is the effective default, so a null row is painted at its default and pinned to an explicit boolean on the next save (behaviour unchanged) - floating save bar (Reset + Save changes) replaces the inline button - Install GitHub App callout, shown only when the App is not installed - preview rail head reuses the rail's own section divider Web-only (@uploads/web is changeset-ignored), so no changeset.
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
uploads-web | d08fb69 | Commit Preview URL Branch Preview URL |
Aug 14 2026, 03:05 PM |
Before / after
Captured against the local dev server with the admin-gated section force-revealed; the Install GitHub App callout is conditional (shown only when the App isn't installed) so it doesn't appear in this unauthenticated capture.
Ports the Claude Design workspace-settings redesign onto the GitHub-comment settings tab (
/account/workspaces/<name>/settings). The app shell, sidebar, and rail already come fromWorkspaceLayout, so this touches only the content section and the preview rail slot.What changed
GitHub comment→ GitHub; new one-line intro; reworded row descriptions;note→ Note (optional),ingest github attachments→ Import GitHub attachments,link to file pages→ Link items to file pages.--radius-sm/mdover the mock's 2px).getGithubInstalled, fail-open, same call the rail uses).role="switch"toggles. Per product decision they write an explicit boolean and drop thenull/"auto" tri-state: a previously-nullrow is painted at its effective default and pinned to that boolean on the next save, so behaviour is unchanged.preview ——divider (matching usage / tip below it) with the "unsaved edits" chip.The floating save bar is currently a one-off. The sibling Storage tab in this same Settings view (
settings/storage.astro) and the admin OAuth editor (admin/oauth/[clientId].astro) still use inline Save buttons — the pattern this page had before. If we want the Settings tabs to feel uniform, a follow-up should migrate those to the same floating bar (happy to do it in a separate PR).Verification
astro check+tsc: 0 errors, 0 warnings600 13px Geist Variable, save bar renders with the solid-accent buttonWeb-only change (
@uploads/webis changeset-ignored) — no changeset.