Clearer screenshots-page tip, header Screenshots link, leaner rail - #693
Conversation
…ner rail - Rewrite the screenshots tip to explain how groupings derive (path meta for page groups, repo/url host for project headings), lead with put --meta over the screenshot command, and link to the public docs - Hide the rail's quick-actions section (invite teammate / GitHub App CTA) on the screenshots tab via a new WorkspaceLayout knob - Retitle the signed-in header's Files link to Screenshots and land it on the active workspace's screenshots tab via an allowlisted ?to=screenshots on the workspaces auto-open (server legacy ?ws= redirect honors it too)
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Both empty states collapse to a title plus one copyable command (matching renderGalleriesEmptyHtml's CTA pattern); the rail tip drops to a single sentence with the docs link carrying the detail.
|
Follow-up pushed: both empty states now match the galleries CTA pattern (title + one copyable |
renderScreenshotsPlaceholderHtml mirrors the React island's OverviewLoadingSkeleton markup, so the gap before the dynamic import resolves shows the same styled skeleton the component renders next — no dead space or layout jump on cold load.
1 participant
What
Follow-ups on the workspace screenshots page:
uploads screenshotcommand; the more common path is a plainputwith metadata. It now explains how the page's groupings actually derive —pathmetadata forms the page groups,repo(or theurlhost) forms the project headings — showsuploads put shot.png --meta path=/settings, and links to the public docs ("how grouping works" → /docs/attach-pull-request-images#put).showQuickActionsknob onWorkspaceLayout(default on); the screenshots page turns the section (invite teammate + GitHub App CTA) off./account/workspaces?to=screenshots, and the workspaces index's auto-open honors the allowlistedtoparam (the server-side legacy?ws=redirect honors it too).Verification
Verified signed-in on the local stack-raw stack:
?to=screenshotsredirects to/account/workspaces/dev-demo/screenshots, the header reads Screenshots, the new tip + docs link render, quick actions are gone, and the narrow-viewport stacked layout is intact. Web tests (630) and typecheck pass.Follow-up
Ambiguous
localhost:3000-style project headings are filed separately as #692 — needs design consideration (derivedrepopreference,--appas a grouping key, or a distinct "local dev" label).