[TE-4877] Fix broken test after Playwright upgrade #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMP LLM model told me this: In Playwright, tests use fixtures like browserName, browser, context, and page. When you set a very short timeout (1ms), the test fails during fixture setup. The newer version of Playwright now times out during the "context" fixture setup (creating the browser context) rather than the "browserName" fixture setup. This is likely because newer Playwright optimizes browser launching to be faster or lazy-loads certain operations, so the timeout now hits later in the setup chain. Playwright fixtures follow a hierarchical setup order: browserName - Simple string constant (chromium/firefox/webkit) browser - Worker-scoped; launches once per worker process (expensive operation) context - Test-scoped; creates isolated browser context (like incognito mode) per test page - Test-scoped; creates a page/tab within the context per test When you set a 1ms timeout, the test fails during fixture setup. The newer Playwright version changed where the timeout triggers—from "browserName" to "context". This suggests the browser launch (browser fixture) now completes faster or is optimized differently, so the 1ms timeout now expires during the context creation step instead of earlier in the chain.
gchan
force-pushed
the
te-4877-soc2-vulnerability-detected-in-test-collector-javascript
branch
from
5bdeecc to
95d68e0
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-79a10363-8be3-4646-b396-ab641d508ec9 Co-authored-by: Amp <[email protected]>
…version differences
|
@nprizal could you please take a look at the spec changes and verify they are sensible and still correctly verify behaviour? |
meghan-kradolfer
approved these changes
Nov 3, 2025
nprizal
approved these changes
Nov 3, 2025
gchan
deleted the
te-4877-soc2-vulnerability-detected-in-test-collector-javascript
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Playwright test expectations after the Playwright upgrade in #121.
The Playwright upgrade changed the fixture lifecycle timing. When a 1ms timeout is set, the timeout now occurs during the
contextfixture setup rather thanbrowserNamefixture setup.This PR updates the test assertions to reflect the new error message format.