Add check in setup.py#416
Closed
woctezuma wants to merge 10 commits intobukson:masterfrom
woctezuma:add-check
Closed
Add check in setup.py#416woctezuma wants to merge 10 commits intobukson:masterfrom woctezuma:add-check
woctezuma wants to merge 10 commits intobukson:masterfrom
woctezuma:add-check
Conversation
Owner
|
I think we should bump minimal python version to 3.10 anyway, so you can change that. The refurbishment pull request makes that possible and seamless right? |
Contributor
Author
|
Yes, the refurbishment was performed with Python 3.12 in mind when running |
Owner
|
So maybe can you set check for python 3.12 and just make it 3.12 project :) I think it is time |
Contributor
Author
|
Alright. I have added minor fixes as well. |
Contributor
Author
|
By the way, maybe, I am missing something, but I don't see where Lines 56 to 69 in 33a5cd9 before it is used in: self.session.cookies.set(**store_cookie) |
Owner
|
Merged manually, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the check which was removed by mistake in:
The check was removed due to https://docs.astral.sh/ruff/rules/outdated-version-block/, because the target version was higher than 3.8.