Add universal binary support for Intel and Apple Silicon Macs#23
Open
ed-would wants to merge 1 commit into
Open
Add universal binary support for Intel and Apple Silicon Macs#23ed-would wants to merge 1 commit into
ed-would wants to merge 1 commit into
Conversation
• build_app — lipo arm64+x86_64 via --triple so one DMG runs on both Macs • do_dmg — assert both slices before packaging; keep build output visible • docs — claim Intel support and correct app size from 590 KB to ~6 MB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arm64+x86_64) release binary so one DMG /.appruns on both Apple Silicon and Intel Macs (macOS 14+).build_app.shbuilds via--tripleand asserts both lipo slices;do_dmg.shre-checks before creating the DMG.Test plan
bash scripts/build_app.shsucceeds on this machinelipo -info ClearDisk.app/Contents/MacOS/ClearDiskshows bothx86_64andarm64open ClearDisk.app— menu bar icon appears and UI works on Intel Macbash scripts/do_dmg.shsucceeds and prints the universal-binary ok linedist/ClearDisk-v1.8.2.dmg, install/open app, confirm it launches