feat(usestore): use selector to replace depActions #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 296 317 +21
Branches 70 80 +10
=========================================
+ Hits 296 317 +21
Continue to review full report at Codecov.
|
kyleslight
reviewed
May 19, 2020
leecade
reviewed
May 19, 2020
| } | ||
| } | ||
| } | ||
|
|
||
| type Equals<X, Y> = (<T>() => T extends X ? 1 : 2) extends <T>() => T extends Y |
| ? [Get<M[K], 'state'>, getConsumerActionsType<Get<M[K], 'actions'>>] | ||
| ? S extends (...args: any) => void | ||
| ? [ | ||
| Equals<ReturnType<S>, unknown> extends true |
src/middlewares.ts
Outdated
| ) { | ||
| setter.selectorRef = setter.selector(Global.State[modelName]) |
There was a problem hiding this comment.
React will check state as shadowEq, double check here is heavy.
ArrayZoneYour
force-pushed
the
feat/selector
branch
from
f0297ac to
5134373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #46