Skip to content

Conversation

igorbeslic
Copy link
Collaborator

Ivica I added CSV sample which fails.
Added test tests number of detected columns - it fails probably because either our wrong configuration or issue in apache library

Header line which cant be processed
Header 1;Header 2;Header 3;;Header 5;;Header 7

Apache parser interprets first ;; as empty header, but it swalows second ;; which causes problem in later output processing

We can check this together before I fix it. (My plan is to provide own parser for header if apache csv fails on this)

@igorbeslic
Copy link
Collaborator Author

  1. Expose convert utils with contex.. (see ContextImpl -> fileBlock)
  2. Try newer version of jackson csv
  3. If newer version of jackson csv has same issue with headers, implement own header reader

@igorbeslic
Copy link
Collaborator Author

@karlocehulic19 let's connect to give you guidelines for this one. It has failing integration test which should PASS once implementation properly process sample CSV file.

@igorbeslic
Copy link
Collaborator Author

@ivicac apache csv requires:
compileOnly group: "org.apache.commons", name: "commons-collections4", version: "4.4" compileOnly group: "org.apache.commons", name: "commons-compress", version: "1.26.0" compileOnly group: "org.apache.commons", name: "commons-csv", version: "1.9.0"

I know that for jackson libs we relie to Spring BOM defined versions

What would be th case for apache??

Btw. according to the plan:

  • @karlocehulic19 would inspect apache impl
  • If not OK, he will do our own implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress
Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

CSV Read Action Must Process Files with delimiter other than coma

1 participant