-
Notifications
You must be signed in to change notification settings - Fork 121
1061 Update ESLint to 9.39.1 #3532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates ESLint from version 8.57.0 to 9.39.1, transitioning from the legacy .eslintrc configuration format to the new flat config format (eslint.config.mjs). This is a major version upgrade that requires significant configuration changes due to ESLint's architectural shift.
Key changes:
- Migration to ESLint 9's flat config format with new configuration files
- Updates to the custom
eslint-plugin-bytechefto support both legacy and flat config formats - Removal of obsolete ESLint disable comments that are no longer needed with the updated ruleset
Reviewed Changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| client/package.json | Updates ESLint to 9.39.1 and adds required flat config dependencies (@eslint/js, @eslint/eslintrc, globals, typescript-eslint) |
| client/eslint.config.mjs | New flat config file replacing .eslintrc with equivalent rules and plugin configurations |
| client/.eslintrc | Removed legacy ESLint configuration file |
| client/.eslintignore | Removed as ignores are now configured in eslint.config.mjs |
| client/.ncurc.json | Removes ESLint from the reject list, allowing future updates |
| client/eslint/package.json | Updates eslint-plugin-bytechef dependencies to ESLint 9 compatible versions |
| client/eslint/eslint.config.mjs | New flat config for the custom ESLint plugin itself |
| client/eslint/.eslintrc.js | Removed legacy config for the custom plugin |
| client/eslint/lib/index.js | Adds flat config exports for the bytechef plugin |
| client/eslint/lib/rules/no-length-jsx-expression.js | Updates to use ESLint 9's context API (getSourceCode().getAncestors) |
| client/eslint/lib/common/imports.js | Updates to use ESLint 9's context API (getSourceCode().getTokenBefore) |
| client/src/shared/types.ts | Removes obsolete @typescript-eslint/no-explicit-any disable comment |
| client/src/shared/components/copilot/runtime-providers/CopilotRuntimeProvider.tsx | Removes obsolete no-constant-condition disable comment |
| client/src/pages/platform/workflow-editor/stores/useRightSidebarStore.ts | Removes obsolete sort-keys disable comment |
| client/src/pages/platform/workflow-editor/stores/useDataPillPanelStore.ts | Removes obsolete sort-keys disable comment |
| client/src/pages/platform/workflow-editor/components/properties/Property.tsx | Removes obsolete react-hooks/exhaustive-deps disable comment |
| client/src/pages/platform/workflow-editor/components/properties/ObjectProperty.tsx | Removes obsolete react-hooks/exhaustive-deps disable comment |
| client/src/pages/automation/template/components/ComponentRow.tsx | Adds no-constant-binary-expression disable comment for intentional dead code |
| client/src/pages/automation/project/components/projects-sidebar/ProjectsLeftSidebar.test.tsx | Removes obsolete @typescript-eslint/no-explicit-any disable comment |
| client/src/ee/pages/settings/platform/api-connectors/components/ApiConnectorEndpointListItem.tsx | Removes obsolete @typescript-eslint/no-explicit-any disable comment |
| client/src/ee/pages/settings/platform/api-connectors/components/ApiConnectorEndpointList.tsx | Removes obsolete @typescript-eslint/no-explicit-any disable comment |
| client/src/ee/pages/embedded/workflow-executions/hooks/useWorkflowExecutions.ts | Removes obsolete @typescript-eslint/no-explicit-any disable comment |
Files not reviewed (1)
- client/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|



No description provided.