Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to retain fetchEvent on all wasi 0.2.x versions #178

Conversation

karthik2804
Copy link
Contributor

Fixes the case where the guest wit states wasi:http/[email protected] but the engine exports wasi:http/[email protected].

@karthik2804 karthik2804 force-pushed the retain_fetchEvent_wasi_patch_versions branch from ba8c2ff to b87cdb2 Compare January 16, 2025 11:31
@karthik2804
Copy link
Contributor Author

Are we okay bumping this to 4s? I see the last few commits have also failed on it.

// TODO: fix back to half a millisecond when Weval fix is added
if (time > 3) {
throw new Error('took more than half a millisecond - ' + time + ' ms');
}

Copy link
Collaborator

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, bumping CI to 4 or 5 seconds would be fine.

crates/spidermonkey-embedding-splicer/src/bindgen.rs Outdated Show resolved Hide resolved
@karthik2804 karthik2804 force-pushed the retain_fetchEvent_wasi_patch_versions branch from 0787fb3 to 775899a Compare January 16, 2025 16:39
@guybedford guybedford merged commit 54bbab4 into bytecodealliance:main Jan 16, 2025
11 checks passed
@karthik2804 karthik2804 deleted the retain_fetchEvent_wasi_patch_versions branch January 16, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants