Skip to content

Expand WIT overview section#288

Merged
vados-cosmonic merged 19 commits into
bytecodealliance:mainfrom
catamorphism:wit-section
Jul 30, 2025
Merged

Expand WIT overview section#288
vados-cosmonic merged 19 commits into
bytecodealliance:mainfrom
catamorphism:wit-section

Conversation

@catamorphism
Copy link
Copy Markdown
Contributor

Most of the changes here are to add semantic line breaks, but I did expand on some concepts, particularly resources.

Copy link
Copy Markdown
Collaborator

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for expanding this section! Left a bunch of comments, mostly nits

Comment thread component-model/src/design/wit.md Outdated
Comment thread component-model/src/design/wit.md Outdated
Comment thread component-model/src/design/wit.md Outdated
Comment thread component-model/src/design/wit.md Outdated
Comment thread component-model/src/design/wit.md Outdated
Comment thread component-model/src/design/wit.md Outdated
Comment thread component-model/src/design/wit.md Outdated
Comment thread component-model/src/design/wit.md Outdated
Comment thread component-model/src/design/wit.md Outdated
Comment thread component-model/src/design/wit.md Outdated
catamorphism and others added 16 commits July 24, 2025 16:37
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Comment thread component-model/src/design/wit.md Outdated
Copy link
Copy Markdown
Collaborator

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Thanks for addressing all the previous suggestions!

Comment thread component-model/src/design/wit.md Outdated
Comment thread component-model/src/design/wit.md Outdated
catamorphism and others added 2 commits July 28, 2025 12:18
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@vados-cosmonic vados-cosmonic merged commit e9fa7ee into bytecodealliance:main Jul 30, 2025
8 checks passed
catamorphism added a commit to catamorphism/component-docs that referenced this pull request Aug 12, 2025
* Expand WIT overview section

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Integrate review feedback into wit.md

* Update component-model/src/design/wit.md

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

* Integrate suggestions from code review

---------

Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants