Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: global find and replace of wasm-tools-go #234

Merged
merged 5 commits into from
Nov 6, 2024
Merged

all: global find and replace of wasm-tools-go #234

merged 5 commits into from
Nov 6, 2024

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Nov 6, 2024 •
edited by ydnar
Loading

Contributes to #232.

@Mossaka Mossaka requested a review from ydnar as a code owner November 6, 2024 00:05
ydnar
ydnar reviewed Nov 6, 2024
View reviewed changes
wit/docs.go Outdated Show resolved Hide resolved
ydnar
ydnar reviewed Nov 6, 2024
View reviewed changes
wit/wit.go Outdated Show resolved Hide resolved
lxfontes
lxfontes reviewed Nov 6, 2024
View reviewed changes
wit/testdata_test.go Outdated Show resolved Hide resolved
lxfontes
lxfontes reviewed Nov 6, 2024
View reviewed changes
wit/resolve.go Outdated Show resolved Hide resolved
lxfontes
lxfontes reviewed Nov 6, 2024
View reviewed changes
wit/codec.go Outdated Show resolved Hide resolved
@ydnar
Copy link
Collaborator

ydnar commented Nov 6, 2024

I think it might be worth doing a first pass of replacing https://github.com/bytecodealliance/wasm-tools-go with https://github.com/bytecodealliance/go-modules before finding and replacing github.com/bytecodealliance/wasm-tools-go with go.bytecodealliance.org.

@Mossaka
Copy link
Member Author

Mossaka commented Nov 6, 2024

Do we want to replace all the https://github.com/bytecodealliance/wasm-tools-go in CHANGELOG.md too?

@ydnar
Copy link
Collaborator

ydnar commented Nov 6, 2024

Do we want to replace all the https://github.com/bytecodealliance/wasm-tools-go in CHANGELOG.md too?

Yes, this will pick up tags, releases, issues, PRs.

@ydnar ydnar changed the title Mass search replace 'github.com/bytecodealliance/wasm-tools-go' -> 'g… all: replace wasm-tools-go with go-modules Nov 6, 2024
@ydnar ydnar changed the title all: replace wasm-tools-go with go-modules all: global find and replace of wasm-tools-go Nov 6, 2024
ydnar
ydnar reviewed Nov 6, 2024
View reviewed changes
wit/docs.go Outdated Show resolved Hide resolved
ydnar
ydnar reviewed Nov 6, 2024
View reviewed changes
wit/wit.go Outdated Show resolved Hide resolved
@Mossaka Mossaka force-pushed the bytecodealliance/main branch from 5f23161 to 56a57f2 Compare November 6, 2024 00:23
@Mossaka Mossaka requested review from ydnar and lxfontes November 6, 2024 00:24
@Mossaka
testdata: re-run make golden
49305c8 
Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
@ydnar ydnar merged commit 92fc9c7 into main Nov 6, 2024
13 checks passed
@ydnar ydnar deleted the bytecodealliance/main branch November 6, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydnar ydnar ydnar approved these changes

@lxfontes lxfontes lxfontes approved these changes

Assignees

@Mossaka Mossaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mossaka @ydnar @lxfontes