Repository navigation
Conversation
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
Contributor
Author
|
@dicej When you get a chance, I'd appreciate another pair of eyes on this. If you'd like to try this out locally, I've drafted a PR with my changes to wit-bindgen: bytecodealliance/wit-bindgen#1779 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17.
Summary
The issue above identified a bug where a panic occurs when a future is cancelled and then written to, when it should be an error. While working on this, I also identified issues with streams permanently blocking after cancellation and added a fix for that as well.
Call outs
There were a couple of ways that we could have handled cancellation. One was to change the futures/streams API to return errors that would report whether a task was cancelled, but decided against this because it would introduce a breaking change and be more tedious for developers to use. I instead chose to use
runtime.Goexit()because it seems to offer the simplest solution; however, I'm open to discussing this further.