-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared heap enhancements #4069
base: dev/shared_heap
Are you sure you want to change the base?
Shared heap enhancements #4069
Conversation
…date function signature
(WASMModuleInstanceCommon *)module_inst); | ||
shared_heap_end_off = get_last_used_shared_heap_end_offset( | ||
(WASMModuleInstanceCommon *)module_inst); | ||
native_addr = shared_heap_base_addr_adj + app_buf_addr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that shared_heap_base_addr_adj
could potentially be NULL
, we should move this line into the if(shared_heap_base_addr_adj)
block around line 1376.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't be NULL if is_app_addr_in_shared_heap
holds true, I will move the 1376 block here
Including two enhancements:
Details can be found in this issue