Switch Subtask trait to taking &self
#1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables having a subtask dispatched based on in-memory variable information as opposed to requiring static information up-front. I'm intending to use this for `wit-dylib` over in wasm-tools to prove out some async bits. This'll eventually happen for futures/streams most likely as well, but for now it's just subtasks. This also shouldn't affect runtime code generated for this crate from before since the types used are all zero-sized and will get elided at runtime. Thus this is intended to enable more use cases without altering existing ones.
dicej
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables having a subtask dispatched based on in-memory variable information as opposed to requiring static information up-front. I'm intending to use this for
wit-dylibover in wasm-tools to prove out some async bits. This'll eventually happen for futures/streams most likely as well, but for now it's just subtasks.This also shouldn't affect runtime code generated for this crate from before since the types used are all zero-sized and will get elided at runtime. Thus this is intended to enable more use cases without altering existing ones.