feat(go): added the missing [resource-drop]
imports for resources
#797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the missing
[resource-drop]
imports for both imported and exported resources in wit-bindgen-go.For import, it implements a wasmimport directory that declares a drop function as an import.
Then the resource can use
Drop()
function to drop their handle. See updated runtime tests for this new update.For exports, the story is a big different. Although I have implemented
Drop<Resourc Name>()
function for each exported resource, I do not find a use case that could utilize this function. Perhaps I am missing something. Nevertheless, I added this function in the generated code which invokes C's drop function given theowning
handler type.