-
Notifications
You must be signed in to change notification settings - Fork 45
chore(ci): Use pre-commit checks in CI #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7939e11 to
ad0409a
Compare
bda35a5 to
f0434d4
Compare
yangzhg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
65ced6c to
7abdc46
Compare
7abdc46 to
d6a597d
Compare
This is better for maintainability as you don't need to edit the pre-commit-config AND the github workflow. Better to just keep it all in one place.
d6a597d to
a479107
Compare
|
@yangzhg thanks for your previous comments and improvements by creating |
What problem does this PR solve?
Use pre-commit checks as CI jobs to prevent relying on pre-commit checks locally. There have already been some PRs which break the formatting rules in the pre-commit checks introduced by #113
Type of Change
Description
Removes the individual clang-format and license-check workflows in favor of just calling
pre-commit run --all-filesto verify all pre-commit checks succeed in the codebase. This prevents needing to maintain multiple workflows for the new checks separate from ourpre-commit-config.yamland also ensures that all new changes follow thepre-commitguidelines defined in the config.Performance Impact
Release Note
N/A
Checklist (For Author)
Breaking Changes