Skip to content

Conversation

@ZacBlanco
Copy link
Collaborator

@ZacBlanco ZacBlanco commented Jan 15, 2026

What problem does this PR solve?

Use pre-commit checks as CI jobs to prevent relying on pre-commit checks locally. There have already been some PRs which break the formatting rules in the pre-commit checks introduced by #113

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

Removes the individual clang-format and license-check workflows in favor of just calling pre-commit run --all-files to verify all pre-commit checks succeed in the codebase. This prevents needing to maintain multiple workflows for the new checks separate from our pre-commit-config.yaml and also ensures that all new changes follow the pre-commit guidelines defined in the config.

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
  • Positive Impact: I have run benchmarks.
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

N/A

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No
  • Yes (Description: ...)

@ZacBlanco ZacBlanco force-pushed the ci-precommit-checks branch 3 times, most recently from 7939e11 to ad0409a Compare January 15, 2026 03:52
@ZacBlanco ZacBlanco marked this pull request as ready for review January 15, 2026 04:14
@ZacBlanco ZacBlanco requested a review from yangzhg January 15, 2026 04:15
@ZacBlanco ZacBlanco force-pushed the ci-precommit-checks branch 2 times, most recently from bda35a5 to f0434d4 Compare January 15, 2026 17:29
Copy link
Collaborator

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZacBlanco ZacBlanco force-pushed the ci-precommit-checks branch 3 times, most recently from 65ced6c to 7abdc46 Compare January 20, 2026 18:06
@ZacBlanco ZacBlanco force-pushed the ci-precommit-checks branch from 7abdc46 to d6a597d Compare January 21, 2026 17:40
@ZacBlanco ZacBlanco force-pushed the ci-precommit-checks branch from d6a597d to a479107 Compare January 23, 2026 07:47
@ZacBlanco
Copy link
Collaborator Author

@yangzhg thanks for your previous comments and improvements by creating license_check.go. I have made a few more improvements to it by using license-eye directly as a library. I also fixed the caching in CI. This check now runs in ~3 minutes when the pre-commit environment is cached. Please take one more pass when you have some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants