[feature][refactor] apply pushed down filters post-scan using Expr framework #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oarap
force-pushed
the
oarap_apply_all_filters_post_scan
branch
2 times, most recently
from
5d557c5 to
5823ac9
Compare
…amework Refactor HiveDataSource to apply pushed down filters and map key pruning to the scan result using the Expr framework. - Replace ad-hoc `evaluateRemainingFilter` with `exec::ExprSet` to standardize post-scan evaluation. - Introduce `postScanExprSet_` to handle both map key pruning (projections) and residual filtering in a single pass. - Add `rowGroupFilter_` to `ScanSpec` to explicitly separate filters used for row group pruning from logical filters applied post-scan. - Update `DwrfData` and `ParquetData` to use `rowGroupFilter` for IO optimization. - Integrate dynamic filters to automatically rebuild the post-scan expression set.
oarap
force-pushed
the
oarap_apply_all_filters_post_scan
branch
from
5823ac9 to
a628218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #164
Type of Change
Description
Refactor HiveDataSource to apply pushed down filters and map key pruning to the scan result using the Expr framework.
evaluateRemainingFilterwithexec::ExprSetto standardize post-scan evaluation.postScanExprSet_to handle both map key pruning (projections) and residual filtering in a single pass.rowGroupFilter_toScanSpecto explicitly separate filters used for row group pruning from logical filters applied post-scan.DwrfDataandParquetDatato userowGroupFilterfor IO optimization.Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes