fix(browser): hide the native browser view while dropdowns and menus are open - #272
Open
shfunc wants to merge 1 commit into
Open
fix(browser): hide the native browser view while dropdowns and menus are open#272shfunc wants to merge 1 commit into
shfunc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropdowns, selects, and context menus opened near the in-app browser render underneath the webpage, so their options are unreachable. The browse pane is a native WebContentsView that composites above the entire DOM; no z-index can fix this.
Dialogs already work around it by hiding the view while open (browser-view.tsx). This does the same for popups: a counter in the app store, bumped by a tiny null component mounted inside the popup portals (portal children only mount while open), and the browser view hides while it's > 0.
Tradeoff: the page goes blank while a menu is open, same as the existing dialog behavior. Tooltips are intentionally excluded to avoid hover flicker.