-
Notifications
You must be signed in to change notification settings - Fork 121
Create cron schedule input #1038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Create cron schedule input #1038
Conversation
Signed-off-by: Assem Hafez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new cron schedule input component that provides individual input fields for each cron expression segment (minute, hour, day of month, month, day of week) with informative popover help text.
- Creates a reusable cron schedule input component with field-specific validation ranges
- Implements popovers for each field showing cron syntax help and allowed value ranges
- Adds comprehensive test coverage for both the main component and popover functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/components/cron-schedule-input/cron-schedule-input.types.ts |
Type definitions for the component props and field configurations |
src/components/cron-schedule-input/cron-schedule-input.tsx |
Main component implementation with input fields and popover integration |
src/components/cron-schedule-input/cron-schedule-input.styles.ts |
Styling definitions for the component layout and input appearance |
src/components/cron-schedule-input/cron-schedule-input.constants.ts |
Configuration constants defining field order, labels, and validation ranges |
src/components/cron-schedule-input/cron-schedule-input-popover/cron-schedule-input-popover.tsx |
Popover component displaying cron syntax help for each field type |
src/components/cron-schedule-input/cron-schedule-input-popover/cron-schedule-input-popover.styles.ts |
Styling for the popover content and layout |
src/components/cron-schedule-input/cron-schedule-input-popover/__tests__/cron-schedule-input-popover.test.tsx |
Unit tests for popover component functionality |
src/components/cron-schedule-input/__tests__/cron-schedule-input.test.tsx |
Comprehensive unit tests for main component behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary
Create a cron schedule input that provides an input for each schedule fragment. Each input has a popover with description for supported values.
Recording
Screen.Recording.2025-09-23.at.16.17.51.mov