feat: History Page V2 - event group row in history grouped table #1095

adhityamamallan · 2025-11-26T11:54:46Z

Summary

Add WorkflowHistoryEventGroup component that renders the single row for an event group
Edit upstream components to pass required props
Implement item expansion in History Page V2 using useExpansionToggle hook
Fixes to grid styling
Add Workflow Actions Modal to History Page V2

Test plan

Added unit tests + ran locally.

Basic table

With hover

Expanded

Reset Workflow form

On narrow screens

Signed-off-by: Adhitya Mamallan <[email protected]>

Copilot

Pull request overview

This PR implements the grouped event view for History v2, introducing a comprehensive event grouping interface with expansion/collapse functionality, duration tracking, and reset capabilities. The changes establish a foundation for displaying workflow history events in a more organized, grouped format.

Key changes:

Added event group rendering with Panel-based UI including status badges, timestamps, and durations
Implemented expansion/collapse state management using a custom hook for individual event groups
Integrated workflow reset functionality with modal support for decision events

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/views/workflow-history-v2/workflow-history-v2.tsx`	Added expansion toggle state management, workflow close time computation, and modal integration for reset functionality
`src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.types.ts`	Extended props to include workflow execution state, event expansion handlers, and reset callbacks
`src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.tsx`	Replaced placeholder with WorkflowHistoryEventGroup component and updated default item height for virtualized rendering
`src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.styles.ts`	Adjusted padding to remove space for expand icon (now hidden) and reduced accordion panel padding
`src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.constants.ts`	Updated grid template columns to accommodate icon, adjusted column proportions for better layout
`src/views/workflow-history-v2/workflow-history-grouped-table/__tests__/workflow-history-grouped-table.test.tsx`	Updated tests to mock WorkflowHistoryEventGroup, removed grid layout test, added new required props to setup
`src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.types.ts`	Defined props interface for event group component with workflow state and interaction handlers
`src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx`	Created event group component with header displaying status, time, duration, and reset button; panel expansion based on event state
`src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.styles.ts`	Defined styled components and overrides for event group panel with grid layout and animation support
`src/views/workflow-history-v2/workflow-history-event-group/helpers/get-event-group-filtering-type.ts`	Implemented helper to determine filtering type based on event group type and attributes
`src/views/workflow-history-v2/workflow-history-event-group/helpers/__tests__/get-event-group-filtering-type.test.ts`	Added comprehensive test coverage for filtering type determination logic
`src/views/workflow-history-v2/workflow-history-event-group/__tests__/workflow-history-event-group.test.tsx`	Created tests for event group rendering, expansion, reset functionality, and loading states
`src/views/workflow-history-v2/workflow-history-event-group-duration/workflow-history-event-group-duration.types.ts`	Defined props for duration component including start/close times and workflow state
`src/views/workflow-history-v2/workflow-history-event-group-duration/workflow-history-event-group-duration.tsx`	Implemented duration component with live updates for ongoing events and conditional rendering
`src/views/workflow-history-v2/workflow-history-event-group-duration/helpers/get-formatted-events-duration.ts`	Created helper to format duration between timestamps with configurable millisecond display
`src/views/workflow-history-v2/workflow-history-event-group-duration/helpers/__tests__/get-formatted-events-duration.test.ts`	Added tests for duration formatting with various time scenarios
`src/views/workflow-history-v2/workflow-history-event-group-duration/__tests__/workflow-history-event-group-duration.test.tsx`	Created tests for duration component behavior including live updates and conditional rendering

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx

...views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.types.ts

Signed-off-by: Adhitya Mamallan <[email protected]>

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

src/views/workflow-history-v2/workflow-history-v2.tsx

src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.tsx

src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx

...w-history-v2/workflow-history-event-group-duration/workflow-history-event-group-duration.tsx

...ow-history-v2/workflow-history-event-group-duration/helpers/get-formatted-events-duration.ts

Assem-Uber · 2025-11-28T13:09:33Z

I have few questions on UI:

How does it look on smaller screens ?
Where are we adding the Starts in badge?
The time and duration fields seems overfitted to the current data. How does workflows with years duration look like ?

...-history-v2/workflow-history-grouped-table/__tests__/workflow-history-grouped-table.test.tsx

Assem-Uber · 2025-11-28T13:11:11Z

...w-history-v2/workflow-history-event-group-duration/workflow-history-event-group-duration.tsx

+import getFormattedEventsDuration from './helpers/get-formatted-events-duration';
+import { type Props } from './workflow-history-event-group-duration.types';
+
+export default function WorkflowHistoryEventGroupDuration({


Do we need to duplicate this component? I expect a single flag returning the value without the badge (only text) would be sufficient.

I will be adding the "starts in" duration here in a future PR.

Starts in will be in the duration column ? Can you please share the mockup for it, it doesn't seem to be easy to understand.

Starts in looks good, can you explain the timer duration. How can it be not fired and have a duration?
Maybe this means the expected timer duration, but if so it seems like we are overloading the duration column with different meanings for the same text.

That makes sense, it's moreso just "time since timer was started" and "time until timer fires"

It's a bit clearer in the actual UI because you can see the left number increasing and the right one decreasing every second

src/views/workflow-history-v2/workflow-history-v2.tsx

...s/workflow-history-v2/workflow-history-event-group/helpers/get-event-group-filtering-type.ts

Assem-Uber · 2025-11-28T13:31:43Z

...s/workflow-history-v2/workflow-history-event-group/helpers/get-event-group-filtering-type.ts

+    }
+  }
+
+  return 'WORKFLOW';


Why are is this filtering by WORKFLOW by default ? shouldn't it be null?

This doesn't do any filtering of its own; rather, it just fetches the group type of the event group. Since we have special logic for signal events, we can't quite use the GroupType field in the history event group itself.

I added 'WORKFLOW' as a fallback, but in practice, that case should never be touched.

I don't see any guarantees that this won't be touched in practice. I tried adding a new groupType for history groups and didn't get any type warnings that i need to add an entry inside workflowHistoryFiltersTypeConfig so it is possible to be missed out and in this case we automatically add it to the WORKFLOW type.

It is better to try to cover this case with types, but if not at least we are aware that this is possible and take the correct decision for it. Don't we have a plan to have OTHER group, i think it can be a good fit as a fallback. Feel free to add it as a TODO if it makes sense.

I agree. For now, 'WORKFLOW' is our "other" group anyway

Added a TODO

adhityamamallan · 2025-12-01T10:52:21Z

How does it look on smaller screens ?

Unfortunately, it's not very usable on small screens for now; I'm thinking of getting rid of the grid layout and just using a flexbox on small screens.

Where are we adding the Starts in badge?

Next to the duration. I was initially planning on adding it to the other badges, but putting it next to duration makes more sense.

The time and duration fields seems overfitted to the current data. How does workflows with years duration look like?

Good point; I already increase the size of the duration column in the follow-up PRs. I can increase the time column size too.

Signed-off-by: Adhitya Mamallan <[email protected]>

adhityamamallan force-pushed the history-v2-grouped-event branch from f772407 to b89db0f Compare November 26, 2025 12:34

adhityamamallan added 6 commits November 26, 2025 13:35

Add grouped table with raw JSON of events

6fcaf28

Signed-off-by: Adhitya Mamallan <[email protected]>

Address copilot comments

c59d9d7

Signed-off-by: Adhitya Mamallan <[email protected]>

base code for grouped event

fbfeecf

Signed-off-by: Adhitya Mamallan <[email protected]>

Add grouped event base

3ab6cce

Signed-off-by: Adhitya Mamallan <[email protected]>

Add unit tests and make some more changes

fc5a27d

Signed-off-by: Adhitya Mamallan <[email protected]>

move from component to hook

74fe264

Signed-off-by: Adhitya Mamallan <[email protected]>

adhityamamallan force-pushed the history-v2-grouped-event branch from b89db0f to 74fe264 Compare November 26, 2025 12:35

adhityamamallan requested a review from Copilot November 26, 2025 12:40

Copilot started reviewing on behalf of adhityamamallan November 26, 2025 12:41 View session

Copilot finished reviewing on behalf of adhityamamallan November 26, 2025 12:45

Copilot AI reviewed Nov 26, 2025

View reviewed changes

Address copilot comments

ac3bd2e

Signed-off-by: Adhitya Mamallan <[email protected]>

adhityamamallan changed the title ~~feat: History v2 grouped event~~ feat: History Page V2 - implement Event Group row in Workflow History Grouped Table Nov 26, 2025

adhityamamallan changed the title ~~feat: History Page V2 - implement Event Group row in Workflow History Grouped Table~~ feat: History Page V2 - event group row in history grouped table Nov 26, 2025

adhityamamallan marked this pull request as ready for review November 26, 2025 14:14

adhityamamallan requested a review from Copilot November 26, 2025 14:14

Copilot started reviewing on behalf of adhityamamallan November 26, 2025 14:14 View session

Copilot finished reviewing on behalf of adhityamamallan November 26, 2025 14:16

Copilot AI reviewed Nov 26, 2025

View reviewed changes

Assem-Uber reviewed Nov 28, 2025

View reviewed changes

adhityamamallan added 2 commits December 1, 2025 13:07

Address comments

606e1c2

Signed-off-by: Adhitya Mamallan <[email protected]>

add todo

1844a74

Signed-off-by: Adhitya Mamallan <[email protected]>

Assem-Uber approved these changes Dec 1, 2025

View reviewed changes

adhityamamallan merged commit 01b2226 into cadence-workflow:master Dec 1, 2025
4 checks passed

feat: History Page V2 - event group row in history grouped table #1095

feat: History Page V2 - event group row in history grouped table #1095

Conversation

adhityamamallan commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Basic table

With hover

Expanded

Reset Workflow form

On narrow screens

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Assem-Uber commented Nov 28, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adhityamamallan Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Assem-Uber Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adhityamamallan commented Dec 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adhityamamallan commented Nov 26, 2025 •

edited

Loading

adhityamamallan Dec 1, 2025 •

edited

Loading

Assem-Uber Dec 1, 2025 •

edited

Loading