feat: [WIP] Task Processing Optimization #7332
Open
+295
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tubignat
requested review from
3vilhamster,
Groxx,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Shaddoll
reviewed
Oct 13, 2025
There was a problem hiding this comment.
We're using pending task tracker to track all the pending tasks in-memory and uses this component to get the ack level of history queues. The in-memory tasks introduced in this PR are NOT tracked by that component, so it's possible that the ack level becomes larger than a pending task.
There was a problem hiding this comment.
And RemoveScheduledTasksAfter should be implemented in a way that invokes Cancel method of task interface on tasks in pending task tracker.
| ts := info.Tasks[i].GetVisibilityTimestamp() | ||
| if ts.Before(nextTime) { | ||
| nextTime = ts | ||
| readLevel := q.base.newVirtualSliceState.Range.InclusiveMinTaskKey.GetScheduledTime() |
There was a problem hiding this comment.
This is the current max read level. The current read level is in virtual slice component. If virtual queue is still trying to read tasks from the database, the task can be submitted twice.
tubignat
force-pushed
the
master
branch
2 times, most recently
from
c98c02e to
b89632f
Compare
tubignat
changed the title
Signed-off-by: Ignat Tubylov <[email protected]>
tubignat
changed the title
tubignat
force-pushed
the
master
branch
2 times, most recently
from
0b87db0 to
4c4f7de
Compare
Signed-off-by: Ignat Tubylov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Timer task queue now keeps incoming tasks in an in-memory queue until the next execution iteration
Why?
To reduce load on DB by avoiding agressively polling it for next timer tasks
How did you test it?
[WIP]
Potential risks
[WIP]