feat: [shard-distributor]Add metrics on number of active shards #7367
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaziza Yestemirova <[email protected]>
gazi-yestemirova
requested review from
3vilhamster,
Groxx,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Signed-off-by: Gaziza Yestemirova <[email protected]>
Signed-off-by: Gaziza Yestemirova <[email protected]>
gazi-yestemirova
changed the title
arzonus
reviewed
Oct 23, 2025
| metricsLoopScope.Tagged( | ||
| metrics.NamespaceTag(p.namespaceCfg.Name), | ||
| metrics.NamespaceTypeTag(p.namespaceCfg.Type), | ||
| ).UpdateGauge(metrics.ShardDistributorActiveShards, float64(totalActiveShards)) |
There was a problem hiding this comment.
Shouldn't we have this metric emitted after the call to shardStore.AssignShards? I think in this case, SD will not emit this metric incorrectly in case of failures of writing to etcd. What do you think?
Signed-off-by: Gaziza Yestemirova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a metric shard_distributor_active_shards along with namespace and namespace_type tag. Metric is emitted during the shard assignment.
Why?
To be able to track number of active shards via dashboards or setup alerts on this metric.
How did you test it?
local testing
Potential risks
N/A
Release notes
Documentation Changes