feat(sharddistributor): add metadata support to executor heartbeat #7369
+474
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
Signed-off-by: Jakob Haahr Taankvist <[email protected]>
jakobht
requested review from
3vilhamster,
Groxx,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
eleonoradgr
approved these changes
Oct 23, 2025
|
|
||
| _maxMetadataKeys = 32 | ||
| _maxMetadataKeyLength = 128 | ||
| _maxMetadataValueSize = 512 * 1024 // 512KB |
There was a problem hiding this comment.
we should move these values to configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
metadatafield (map<string, string>) toHeartbeatRequestprotoWhy?
Enable executors to attach generic metadata to heartbeat requests for flexible context sharing.
How did you test it?
Added unit tests for metadata validation and ETCD storage integration.
Potential risks
Low - new optional field, no changes to existing functionality.
Release notes
None - experimental shard distributor feature.
Documentation Changes
None required.