Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy seeds not being displayed when polyseed is not supported #1608

Merged
merged 2 commits into from
Aug 17, 2024
Merged

Fix legacy seeds not being displayed when polyseed is not supported #1608

merged 2 commits into from
Aug 17, 2024

Conversation

MrCyjaneK
Copy link
Collaborator

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • make getters less strict polyseed_dart#4 <- merge this and update polyseed, using pinned git hash from my fork for now.
  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

OmarHatem28
OmarHatem28 approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@OmarHatem28 OmarHatem28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since 0.0.6 is live I will switch to it in a different branch

@OmarHatem28 OmarHatem28 merged commit eef3196 into main Aug 17, 2024
2 checks passed
@OmarHatem28 OmarHatem28 deleted the cyjan-seed-fix-continued branch August 17, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarHatem28 OmarHatem28 OmarHatem28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrCyjaneK @OmarHatem28