Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CW-942-New-Swap-UI-Flow #2036

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

CW-942-New-Swap-UI-Flow #2036

wants to merge 9 commits into from

Conversation

Blazebrain
Copy link
Contributor

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

…extract common fee logic to a feeViewModel, use that in SendViewModel and ExchangeViewModel
…ct common fee logic to a feeViewModel for use in SendViewModel and ExchangeViewModel
@@ -128,8 +135,20 @@ class TradeItemRowWidget extends StatelessWidget {
required this.copyImage,
});

// Please change this
ThemeBase get currentTheme => getIt.get<SettingsStore>().currentTheme;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Blazebrain Can you please see if there is a better way to handle getting currentTheme here

@Blazebrain Blazebrain requested a review from tuxpizza February 27, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants