Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cw 855 transactions not cleared correctly when switching wallets #2040

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Serhii-Borodenko
Copy link
Contributor

@Serhii-Borodenko Serhii-Borodenko commented Feb 20, 2025

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

Copy link
Contributor

@OmarHatem28 OmarHatem28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is another connectMapToListWithTransform in the constructor so probably you should convert it too
but I want to make sure that this approach will indeed trigger the reaction for all change types like it's currently doing in connectMapToListWithTransform
compare the code in there and see if it will achieve the same or would it have any side effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants