CW-909-monero-background-sync-investigation #2041

MrCyjaneK · 2025-02-21T08:06:26Z

Description

Improve error handling and status checks during background sync
Modify zano init method to not conflict with default init()
Add dev tools for background sync monitoring and manual rescan

Pull Request - Checklist

Initial Manual Tests Passed
Double check modified code and verify it with the feature/task requirements
Format code
Look for code duplication
Clear naming for variables and methods

…mweb-bg-sync-2

…mweb

…mweb-bg-sync-2

Co-authored-by: Omar Hatem <[email protected]>

…mweb

Co-authored-by: Omar Hatem <[email protected]>

…mweb-bg-sync-2

…mweb-bg-sync-3

…llet into mweb-bg-sync-3

…let types - Improve error handling and status checks during background sync - Modify zano init method to not conflict with default init() - Add dev tools for background sync monitoring and manual rescan

[DNM] Enable debug screen on release to test

don't close monero wallets on AppLifecycleState.paused

…CW-909-monero-background-sync-investigation

OmarHatem28

@fossephate please continue on this branch and fix the comments here
also, please make the notifications and its settings only in debug mode
and make the whole background tile in the settings only show up on Android

lib/di.dart

cw_bitcoin/lib/electrum_wallet.dart

cw_monero/lib/api/account_list.dart

OmarHatem28 · 2025-02-25T02:29:28Z

cw_monero/lib/api/subaddress_list.dart

+  if (monero.Wallet_numSubaddressAccounts(wptr!) <= accountIndex) {
+    printV("accountIndex is out of bounds");
+    return;
+  }


why? wouldn't it create the account normally and then create the subaddress?

In background sync it is numSubaddressAccount is always zero.

cw_zano/lib/zano_wallet.dart

OmarHatem28 · 2025-02-25T20:02:40Z

lib/entities/background_tasks.dart

+        final firstWallet = litecoinWallets.first;
+        final wallet = await walletLoadingService.load(firstWallet.type, firstWallet.name);
+        await wallet.stopSync();
+        if (bitcoin!.getMwebEnabled(wallet)) {
+          syncingWallets.add(wallet);
+        }


what if the first wallet doesn't have mweb enabled,
loop through them until you find one that has mweb enabled then add it and break

ah right I forgot we changed mweb to be a per-wallet setting

OmarHatem28 · 2025-02-25T20:06:28Z

lib/entities/background_tasks.dart

+        var node = settingsStore.getCurrentNode(WalletType.bitcoin);
+        await wallet.connectToNode(node: node);
+
+        bool nodeSupportsSP = await (wallet as ElectrumWallet).getNodeSupportsSilentPayments();
+        if (!nodeSupportsSP) {


shouldn't we first check on whether silent payment scanning is enabled or not

OmarHatem28 · 2025-02-25T20:23:24Z

ios/Runner/AppDelegate.swift

@@ -20,6 +20,7 @@ import workmanager
        }

        WorkmanagerPlugin.registerTask(withIdentifier: "com.fotolockr.cakewallet.monero_sync_task")
+        WorkmanagerPlugin.registerTask(withIdentifier: "com.fotolockr.cakewallet.mweb_sync_task")


I don't see a need for this, the feature is only android and this is not used

cw_monero/lib/api/wallet.dart

OmarHatem28 · 2025-02-25T20:53:09Z

lib/entities/load_current_wallet.dart

+  // TODO: re-enable (need to figure out how to prevent current wallet from being loaded in the background service!)
+  // STILL TODO:!


still todo?!
I see you already added the loadWallet: false, but just need to make sure it's the only way the current wallet is loaded

Co-authored-by: Omar Hatem <[email protected]>

fossephate and others added 30 commits September 4, 2024 15:50

wip

7b5c36e

wip

aa6cac8

[skip ci] wip

c8aa159

updates [skip ci]

20fa6a0

ios fixes

14891ec

fix workflows + ios fix

5dbc414

Merge branch 'mweb' of https://github.com/cake-tech/cake_wallet into …

a87a028

…mweb-bg-sync-2

Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …

fbffda7

…mweb

Merge branch 'mweb' of https://github.com/cake-tech/cake_wallet into …

a812ea8

…mweb-bg-sync-2

test old mweb version

bae741a

update go version and mwebd hash

ec60fa9

Merge branch 'mweb' of https://github.com/cake-tech/cake_wallet into …

91ab7ed

…mweb-bg-sync-2

sync first wallet

5d7db4e

minor fix

91f4904

review updates pt.1

56c505d

Update cw_bitcoin/lib/litecoin_wallet.dart

0f5ee47

Co-authored-by: Omar Hatem <[email protected]>

remove non-litecoin address types regex [skip ci]

577aec0

Merge remote-tracking branch 'origin/mweb' into mweb

729df41

more minor fixes

728a0bf

Merge branch 'mweb' of https://github.com/cake-tech/cake_wallet into …

69297d2

…mweb

Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …

3a70d72

…mweb

remove duplicate [skip ci]

18a9bde

Update lib/store/settings_store.dart

dc77dee

Co-authored-by: Omar Hatem <[email protected]>

script updates, swap params on createLitecoinWalletService

fd578dd

topup fix

3963233

Merge branch 'mweb' of https://github.com/cake-tech/cake_wallet into …

910825d

…mweb-bg-sync-2

[skip ci] wip

1061b7d

[skip ci] testing

150d065

Merge branch 'mweb' of https://github.com/cake-tech/cake_wallet into …

5be1284

…mweb-bg-sync-2

[skip ci] file didn't get saved

69332b3

fossephate added 11 commits January 6, 2025 17:16

cleanup [skip ci]

c59e4df

cleanup [skip ci]

cab76cc

save

df70bb7

[skip ci] wip

a9f7dec

experimental

582830d

save

840c151

cleanup

b089d92

updates to bg sync

53dd533

Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …

cc3eec6

…mweb-bg-sync-3

Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …

399aaff

…mweb-bg-sync-3

[skip ci] Merge branch 'main' of https://github.com/cake-tech/cake_wa…

fddbe7c

…llet into mweb-bg-sync-3

MrCyjaneK changed the base branch from mweb-bg-sync-3 to main February 21, 2025 08:06

MrCyjaneK force-pushed the CW-909-monero-background-sync-investigation branch from ce81a26 to fddbe7c Compare February 21, 2025 08:09

MrCyjaneK added 5 commits February 21, 2025 09:10

Merge branch 'main' into CW-909-monero-background-sync-investigation

6c04666

Enhance background sync and wallet initialization across multiple wal…

fcc2769

…let types - Improve error handling and status checks during background sync - Modify zano init method to not conflict with default init() - Add dev tools for background sync monitoring and manual rescan

fix generated code, fix zano, update monero_c

dc04009

[skip slack] remove print statement

1493dd4

Clear status code to prevent errors during bg sync

1287a31

[DNM] Enable debug screen on release to test

MrCyjaneK added the Work in Progress label Feb 21, 2025

fossephate and others added 6 commits February 21, 2025 18:39

[skip-ci] merge main

8c02973

don't create subaddresses on out of bounds accounts

025f7a9

don't stop wallet when coming back to the foreground

74b0076

final fix for background sync

900475f

don't close monero wallets on AppLifecycleState.paused

Merge branch 'main' into CW-909-monero-background-sync-investigation

cfbf1f7

Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …

feeba34

…CW-909-monero-background-sync-investigation

OmarHatem28 reviewed Feb 28, 2025

View reviewed changes

fossephate and others added 4 commits March 2, 2025 01:51

Update lib/di.dart

c7a2388

Co-authored-by: Omar Hatem <[email protected]>

remove unnecessary timeout

6112d49

Co-authored-by: Omar Hatem <[email protected]>

Update cw_zano/lib/zano_wallet.dart

cf91996

Co-authored-by: Omar Hatem <[email protected]>

enable debug screen only in debug

a6d16bb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CW-909-monero-background-sync-investigation #2041

CW-909-monero-background-sync-investigation #2041

MrCyjaneK commented Feb 21, 2025

OmarHatem28 left a comment

OmarHatem28 Feb 25, 2025

fossephate Mar 2, 2025

MrCyjaneK Mar 2, 2025

OmarHatem28 Feb 25, 2025

fossephate Mar 2, 2025

OmarHatem28 Feb 25, 2025

OmarHatem28 Feb 25, 2025

OmarHatem28 Feb 25, 2025

		// TODO: re-enable (need to figure out how to prevent current wallet from being loaded in the background service!)
		// STILL TODO:!

CW-909-monero-background-sync-investigation #2041

Are you sure you want to change the base?

CW-909-monero-background-sync-investigation #2041

Conversation

MrCyjaneK commented Feb 21, 2025

Description

Pull Request - Checklist

OmarHatem28 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment