CW-912 [1/?] one class per file, minor cleanups #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix build issue, update deps bump monero_c
update lints move settings widgets into separate files
update to RC10 monero_c use xcframework instead of .framework
add lints make all final variables final fix Makefile, use prebuilds on CI simplify format.sh script global fatal error handling add new method on coin to see if seed appears legit await all async calls make FormElement properly abstract and add errorHandler remove BuildContext from where it's not required simplify validator in FormElement, create templates move renameWallet and createWallet to ViewModel remove deprecated methods in QrImageView Add insecure biometric option add codegen @RebuildOnChange - can be user in ViewModel and automatically rebuilds the UI on change @ExposeRebuildableAccessors - makes it easy to expose all accessors of a class in ViewModel - used in SettingsViewModel to simlify code. @ThrowOnUI - show an error to the user when a function throws
remove button classes from view separate new_wallet data classes from view model extractract nested widgets into methods remove logic from ui
bump flutter version sneak in GPL-3.0 relicense little tiny start on docs
use translations instead of hardcoded strings reorganize code cleanup all classes
OmarHatem28
reviewed
Feb 23, 2025
| final byteWords = s2[2]; | ||
| bw += byteWords; | ||
| } | ||
| String? error; |
There was a problem hiding this comment.
not initialized, shouldn't we wrap the above in a try/catch and initialize this in the catch block?
CW-912 [2/?] View cleanup
Co-authored-by: Omar Hatem <[email protected]>
CW-912 [4/?] Many more changes
CW-912 [3/?] Cleanup cont'd
CW-912 [7/?] Possibly last PR in this series
OmarHatem28
reviewed
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.