Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: middleware logic Routing Forms #10412

Merged
merged 2 commits into from
Jul 27, 2023
Merged

fix: middleware logic Routing Forms #10412

merged 2 commits into from
Jul 27, 2023

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Jul 27, 2023

What does this PR do?

Fixes following:

  • Super important fix, spread operator doesn't work with config.matcher of middleware. So, even though it's working with Next.js, it might not work with Vercel.
Screenshot 2023-07-27 at 12 57 11 PM
  • 404 on /apps/routing_forms
  • 404 on /routing-forms

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Visit /apps/routing_forms and /routing-forms. They should not be 404
  • Visit /routing-forms/forms - It should also work

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 7:31am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 7:31am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 7:31am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jul 27, 2023 7:31am
qa ⬜️ Ignored (Inspect) Jul 27, 2023 7:31am
ui ⬜️ Ignored (Inspect) Visit Preview Jul 27, 2023 7:31am

@zomars zomars added the core area: core, team members only label Jul 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Thank you for following the naming conventions! 🙏

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Jul 27, 2023

🤖 Meticulous spotted visual differences in 46 of 171 screens tested: view and approve differences detected.

Last updated for commit 69e3a86. This comment will update as new commits are pushed.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented Jul 27, 2023

Current Playwright Test Results Summary

✅ 105 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/27/2023 07:33:35am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 69e3a86

Started: 07/27/2023 07:32:01am UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
1.50% (3) 3 / 200 runs
failed over last 7 days
95.50% (191) 191 / 200 runs
flaked over last 7 days

View Detailed Build Results


@emrysal emrysal merged commit 48b79b6 into main Jul 27, 2023
31 of 33 checks passed
@emrysal emrysal deleted the fix/404-routing_forms branch July 27, 2023 11:18
sean-brydon pushed a commit that referenced this pull request Jul 31, 2023
* Match /apps/routing_forms

* Next.js config.matcher doesnt support spread operator
sean-brydon pushed a commit that referenced this pull request Aug 1, 2023
* Match /apps/routing_forms

* Next.js config.matcher doesnt support spread operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants