Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email embed illustraion #10427

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

PeerRich
Copy link
Member

CleanShot%202023-07-27%20at%2022 12 53@2x
CleanShot%202023-07-27%20at%2022 13 06@2x

@PeerRich PeerRich linked an issue Jul 27, 2023 that may be closed by this pull request
@linear
Copy link

linear bot commented Jul 27, 2023

@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 8:30pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 8:30pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 8:30pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 8:30pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jul 27, 2023 8:30pm
qa ⬜️ Ignored (Inspect) Jul 27, 2023 8:30pm

@github-actions github-actions bot added the 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup label Jul 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Jul 27, 2023
@PeerRich PeerRich requested a review from ciaranha July 27, 2023 20:20
@PeerRich PeerRich added ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work Low priority Created by Linear-GitHub Sync and removed 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup labels Jul 27, 2023
@PeerRich PeerRich changed the title fixed email embed illustraion fix: email embed illustraion Jul 27, 2023
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Jul 27, 2023

🤖 Meticulous spotted visual differences in 25 of 309 screens tested: view and approve differences detected.

Last updated for commit 9447139. This comment will update as new commits are pushed.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 613.55 KB 767.64 KB 219.33% (🟡 +0.21%)
/event-types 593.43 KB 747.52 KB 213.58% (🟡 +0.22%)
/event-types/[type] 477.39 KB 631.48 KB 180.42% (🟡 +0.22%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link

deploysentinel bot commented Jul 27, 2023

Current Playwright Test Results Summary

✅ 106 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/27/2023 08:31:10pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 9447139

Started: 07/27/2023 08:28:50pm UTC

⚠️ Flakes

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED can submit a form and get a submission event
Retry 1Initial Attempt
2.30% (7) 7 / 305 runs
failed over last 7 days
10.82% (33) 33 / 305 runs
flaked over last 7 days

📄   packages/app-store/typeform/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1Initial Attempt
5.93% (7) 7 / 118 runs
failed over last 7 days
11.02% (13) 13 / 118 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
2.31% (7) 7 / 303 runs
failed over last 7 days
2.64% (8) 8 / 303 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
1.30% (3) 3 / 231 runs
failed over last 7 days
95.24% (220) 220 / 231 runs
flaked over last 7 days

View Detailed Build Results


@emrysal emrysal merged commit 96fb3a3 into main Jul 27, 2023
29 of 30 checks passed
@emrysal emrysal deleted the 10420-cal-2265-fix-email-embed-illustration branch July 27, 2023 20:31
@ciaranha
Copy link
Member

Looks goood!

sean-brydon pushed a commit that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[CAL-2265] fix email embed illustration
4 participants