-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Organization's Team invite emails #12843
fix: Organization's Team invite emails #12843
Conversation
@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Thank you for the PR! We've labeled it accordingly. Please ensure that any changes are well-documented and that you've followed the contribution guidelines. If there are any additional cases that use the |
@@ -12,24 +12,30 @@ type TeamInvite = { | |||
joinLink: string; | |||
isCalcomMember: boolean; | |||
isOrg: boolean; | |||
parentTeamName: string | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parentTeamName: string | undefined; | |
parentTeamName?: string; |
It makes more sense. As parentTeamName itself isn't undefined but the caller can choose to not pass this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SomayChauhan Thanks and great work !!
What does this PR do?
Fixes #12804
FOR ORGANIZATIONS
1. invite a member to a organization and resend invite (no change)
2. add a pending member to a sub-team (change)
before
after
3. add a pending member to a sub-team and clicking on resend invite (change)
before
after
4. invite a member to a subTeam directly (change)
before
after
5. invite a member to a subTeam directly and click on resend invite from sub-team members page (change)
before
after
FOR NORMAL TEAMS
1. invite a member to a Team directly and click on resend invite (no change)
PS:
team-invite-email
email template, however there maybe more that i could've missed, in that case do let me know.thank you.