-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use org logo for organization's teams #12961
fix: Use org logo for organization's teams #12961
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
c489414
to
bef1f6f
Compare
bef1f6f
to
a4b1865
Compare
62b0402
to
d162828
Compare
d162828
to
ea3cd09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about to be deprecated according to @emrysal
I think #12716 Should do this and it is also a bit cleaner. I need to fix e2e tests when i get a chance but i think this is a better approach? Let me know if there is something i am missing here |
@sean-brydon your PR is certainly cleaning things up and would be happy to merge it but I don't think it's fixing the bugs(didn't test though). I can clearly see that there are no changes in event-types/index.tsx and TeamListItem.tsx in that PR |
Yeah youre right - that PR did not fix any bugs just cleaned up the approach to handle the orgLogo. Would you be up for migrating this PR over to that approach? It does require fetching more info for the orgs other than just the organizationID - but i think we should have that in session. Just ping me if you want me to take this over instead |
Hey there, there is a merge conflict, can you take a look? |
@sean-brydon @hariombalhara should we close this one? |
Yeah I think someone fixed it already. |
What does this PR do?
Fixes #12956 #12957
When organization has no logo uploaded
Non-Org teams still show their logo but org sub-teams now show the logo of the org.
Create Event Type Dropdown
Teams listing
New Webhook dropdown
Engineering Team Booking Page - Engineering Team is a team inside Org1
When organization has logo uploaded.
Non-Org teams still show their logo but org sub-teams now show the logo of the org.
Create Event Type Dropdown
Teams listing
New Webhook dropdown
Engineering Team Booking Page - Engineering Team is a team inside Org1
Seeded Team booking Page
Type of change
How should this be tested?
See the screenshots
Mandatory Tasks
Checklist