Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: one off booking #12976

Closed
wants to merge 3 commits into from
Closed

feat: one off booking #12976

wants to merge 3 commits into from

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Jan 2, 2024

What does this PR do?

Fixes #12571
Fixes #7595

Type of change

  • Feature

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 3:03pm
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 3:03pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 3:03pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2024 3:03pm
cal-demo ⬜️ Ignored (Inspect) Jan 20, 2024 3:03pm
qa ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2024 3:03pm
ui ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2024 3:03pm

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added Medium priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/one-time-booking 255.36 KB 421.48 KB 120.42%

Sixty-seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 269.95 KB 436.06 KB 124.59% (🟡 +0.15%)
/apps/[slug] 287.66 KB 453.78 KB 129.65% (🟡 +0.15%)
/apps/[slug]/[...pages] 547.33 KB 713.44 KB 203.84% (🟡 +0.15%)
/apps/categories 247.9 KB 414.01 KB 118.29% (🟡 +0.15%)
/apps/categories/[category] 252.17 KB 418.29 KB 119.51% (🟡 +0.15%)
/apps/installed/[category] 271.26 KB 437.38 KB 124.96% (🟡 +0.15%)
/auth/setup 150.88 KB 317 KB 90.57% (🟡 +0.15%)
/availability/[schedule] 351.65 KB 517.77 KB 147.93% (🟡 +0.15%)
/availability/troubleshoot 170.7 KB 336.81 KB 96.23% (🟡 +0.17%)
/enterprise 248.37 KB 414.48 KB 118.42% (🟡 +0.15%)
/event-types 545.93 KB 712.05 KB 203.44% (🟡 +0.19%)
/event-types/[type] 421.44 KB 587.55 KB 167.87% (🟡 +0.15%)
/getting-started/[[...step]] 402.9 KB 569.02 KB 162.58% (🟡 +0.14%)
/insights 474.19 KB 640.31 KB 182.95% (🟡 +0.15%)
/more 247.53 KB 413.64 KB 118.18% (🟡 +0.15%)
/settings/admin 254.21 KB 420.33 KB 120.09% (🟡 +0.15%)
/settings/admin/apps 267.46 KB 433.58 KB 123.88% (🟡 +0.15%)
/settings/admin/apps/[category] 267.45 KB 433.57 KB 123.88% (🟡 +0.14%)
/settings/admin/flags 257.97 KB 424.08 KB 121.17% (🟡 +0.14%)
/settings/admin/impersonation 254.5 KB 420.62 KB 120.18% (🟡 +0.14%)
/settings/admin/oAuth 266.22 KB 432.33 KB 123.52% (🟡 +0.15%)
/settings/admin/oAuth/oAuthView 92.1 KB 258.22 KB 73.78% (🟡 +0.14%)
/settings/admin/orgMigrations/_OrgMigrationLayout 246.97 KB 413.09 KB 118.03% (🟡 +0.14%)
/settings/admin/orgMigrations/moveTeamToOrg 263.74 KB 429.86 KB 122.82% (🟡 +0.14%)
/settings/admin/orgMigrations/moveUserToOrg 282.2 KB 448.32 KB 128.09% (🟡 +0.15%)
/settings/admin/orgMigrations/removeTeamFromOrg 263.5 KB 429.62 KB 122.75% (🟡 +0.14%)
/settings/admin/orgMigrations/removeUserFromOrg 263.51 KB 429.63 KB 122.75% (🟡 +0.15%)
/settings/admin/organizations 256.23 KB 422.35 KB 120.67% (🟡 +0.15%)
/settings/admin/organizations/[id]/edit 254.72 KB 420.84 KB 120.24% (🟡 +0.15%)
/settings/admin/users 256.92 KB 423.03 KB 120.87% (🟡 +0.14%)
/settings/admin/users/[id]/edit 356.38 KB 522.5 KB 149.28% (🟡 +0.15%)
/settings/admin/users/add 356.12 KB 522.23 KB 149.21% (🟡 +0.15%)
/settings/billing 254.41 KB 420.53 KB 120.15% (🟡 +0.15%)
/settings/developer/api-keys 258.83 KB 424.94 KB 121.41% (🟡 +0.15%)
/settings/developer/webhooks 258.74 KB 424.86 KB 121.39% (🟡 +0.14%)
/settings/developer/webhooks/[id] 259.78 KB 425.89 KB 121.68% (🟡 +0.15%)
/settings/developer/webhooks/new 259.81 KB 425.93 KB 121.69% (🟡 +0.15%)
/settings/my-account/appearance 277.92 KB 444.03 KB 126.87% (🟡 +0.14%)
/settings/my-account/calendars 265.19 KB 431.3 KB 123.23% (🟡 +0.15%)
/settings/my-account/conferencing 266.05 KB 432.16 KB 123.47% (🟡 +0.15%)
/settings/my-account/general 342.53 KB 508.64 KB 145.33% (🟡 +0.14%)
/settings/my-account/out-of-office 258.63 KB 424.74 KB 121.36% (🟡 +0.14%)
/settings/organizations/[id]/about 154.44 KB 320.55 KB 91.59% (🟡 +0.14%)
/settings/organizations/[id]/add-teams 154.49 KB 320.61 KB 91.60% (🟡 +0.15%)
/settings/organizations/[id]/onboard-admins 154.54 KB 320.66 KB 91.62% (🟡 +0.14%)
/settings/organizations/[id]/set-password 154.42 KB 320.54 KB 91.58% (🟡 +0.15%)
/settings/organizations/appearance 277.8 KB 443.91 KB 126.83% (🟡 +0.15%)
/settings/organizations/billing 254.45 KB 420.57 KB 120.16% (🟡 +0.15%)
/settings/organizations/general 335.07 KB 501.19 KB 143.20% (🟡 +0.14%)
/settings/organizations/members 421.64 KB 587.76 KB 167.93% (🟡 +0.15%)
/settings/organizations/new 154.44 KB 320.55 KB 91.59% (🟡 +0.14%)
/settings/organizations/teams/other 255.28 KB 421.4 KB 120.40% (🟡 +0.15%)
/settings/organizations/teams/other/[id]/appearance 266.87 KB 432.99 KB 123.71% (🟡 +0.15%)
/settings/organizations/teams/other/[id]/members 261.52 KB 427.64 KB 122.18% (🟡 +0.15%)
/settings/security/impersonation 259.51 KB 425.62 KB 121.61% (🟡 +0.14%)
/settings/security/password 268.46 KB 434.58 KB 124.17% (🟡 +0.14%)
/settings/security/sso 264.49 KB 430.61 KB 123.03% (🟡 +0.15%)
/settings/security/two-factor-auth 263.33 KB 429.45 KB 122.70% (🟡 +0.15%)
/settings/teams 253.95 KB 420.06 KB 120.02% (🟡 +0.14%)
/settings/teams/[id]/appearance 266.86 KB 432.98 KB 123.71% (🟡 +0.14%)
/settings/teams/[id]/billing 254.45 KB 420.57 KB 120.16% (🟡 +0.15%)
/settings/teams/[id]/onboard-members 158.25 KB 324.36 KB 92.68% (🟡 +0.14%)
/settings/teams/[id]/sso 265.01 KB 431.13 KB 123.18% (🟡 +0.15%)
/settings/teams/new 190.92 KB 357.04 KB 102.01% (🟡 +0.15%)
/teams 247.8 KB 413.92 KB 118.26% (🟡 +0.15%)
/upgrade 247.98 KB 414.09 KB 118.31% (🟡 +0.15%)
/workflows 286.26 KB 452.38 KB 129.25% (🟡 +0.15%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

deploysentinel bot commented Jan 20, 2024

Current Playwright Test Results Summary

✅ 396 Passing - ❌ 3 Failing - ⚠️ 31 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/20/2024 03:07:11pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: dab6ccf

Started: 01/20/2024 02:58:09pm UTC

❌ Failures

📄   apps/web/playwright/booking/availability.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Check availability tab in a event-type Check availability in event type
Retry 2Retry 1Initial Attempt
Error: Test timeout of 60000ms exceeded.
Test timeout of 60000ms exceeded.
28.26% (65) 65 / 230 runs
failed over last 7 days
31.74% (73) 73 / 230 runs
flaked over last 7 days

📄   apps/web/playwright/insights.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Insights should be able to switch between memberUsers
Retry 2Retry 1Initial Attempt
Error: Test timeout of 60000ms exceeded.
Test timeout of 60000ms exceeded.
0.78% (3) 3 / 385 runs
failed over last 7 days
0.26% (1) 1 / 385 run
flaked over last 7 days

📄   apps/web/playwright/workflow.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Workflow Tab - Event Type Check the functionalities of the Workflow Tab User Workflows Create an action and check if workflow is triggered
Retry 2Retry 1Initial Attempt
Error: page.goto: net::ERR_ABORTED at http://localhost:3000/user-1-1705762805768/30-min...
page.goto: net::ERR_ABORTED at http://localhost:3000/user-1-1705762805768/30-min
=========================== logs ===========================
navigating to "http://localhost:3000/user-1-1705762805768/30-min", waiting until "load"
============================================================
0.83% (2) 2 / 240 runs
failed over last 7 days
4.17% (10) 10 / 240 runs
flaked over last 7 days

⚠️ Flakes

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user Time slots should be reserved when selected
Retry 1Initial Attempt
0% (0) 0 / 363 runs
failed over last 7 days
6.34% (23) 23 / 363 runs
flaked over last 7 days

📄   apps/web/playwright/booking/selectQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Select Question and Multi email Question Select required and Multi email required
Retry 1Initial Attempt
0.27% (1) 1 / 369 run
failed over last 7 days
2.17% (8) 8 / 369 runs
flaked over last 7 days
Booking With Phone Question and Each Other Question Booking With Select Question and Number Question Select required and Number required
Retry 1Initial Attempt
0% (0) 0 / 367 runs
failed over last 7 days
3.54% (13) 13 / 367 runs
flaked over last 7 days

📄   apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Short text question Radio and Short text not required
Retry 1Initial Attempt
0.27% (1) 1 / 371 run
failed over last 7 days
3.23% (12) 12 / 371 runs
flaked over last 7 days

📄   apps/web/playwright/locale.e2e.ts • 13 Flakes

Top 1 Common Error Messages

null

13 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 1Initial Attempt
-26.58% (-97) -97 / 365 runs
failed over last 7 days
26.58% (97) 97 / 365 runs
flaked over last 7 days
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 1Initial Attempt
-26.58% (-97) -97 / 365 runs
failed over last 7 days
26.58% (97) 97 / 365 runs
flaked over last 7 days
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 1Initial Attempt
-26.65% (-97) -97 / 364 runs
failed over last 7 days
26.65% (97) 97 / 364 runs
flaked over last 7 days
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 1Initial Attempt
-26.65% (-97) -97 / 364 runs
failed over last 7 days
26.65% (97) 97 / 364 runs
flaked over last 7 days
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 1Initial Attempt
-26.65% (-97) -97 / 364 runs
failed over last 7 days
26.65% (97) 97 / 364 runs
flaked over last 7 days
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 1Initial Attempt
-26.65% (-97) -97 / 364 runs
failed over last 7 days
26.65% (97) 97 / 364 runs
flaked over last 7 days
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 1Initial Attempt
-26.65% (-97) -97 / 364 runs
failed over last 7 days
26.65% (97) 97 / 364 runs
flaked over last 7 days
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 1Initial Attempt
-26.65% (-97) -97 / 364 runs
failed over last 7 days
26.65% (97) 97 / 364 runs
flaked over last 7 days
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 1Initial Attempt
-26.72% (-97) -97 / 363 runs
failed over last 7 days
26.72% (97) 97 / 363 runs
flaked over last 7 days
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 1Initial Attempt
-26.72% (-97) -97 / 363 runs
failed over last 7 days
26.72% (97) 97 / 363 runs
flaked over last 7 days
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 1Initial Attempt
-26.72% (-97) -97 / 363 runs
failed over last 7 days
26.72% (97) 97 / 363 runs
flaked over last 7 days
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 1Initial Attempt
-9.12% (-33) -33 / 362 runs
failed over last 7 days
25.41% (92) 92 / 362 runs
flaked over last 7 days
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 1Initial Attempt
-18.81% (-57) -57 / 303 runs
failed over last 7 days
30.36% (92) 92 / 303 runs
flaked over last 7 days

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 2Retry 1Initial Attempt
0.28% (1) 1 / 362 run
failed over last 7 days
34.81% (126) 126 / 362 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail Team invitation
Retry 2Retry 1Initial Attempt
2.73% (11) 11 / 403 runs
failed over last 7 days
25.56% (103) 103 / 403 runs
flaked over last 7 days
Organization Email matching orgAutoAcceptEmail and a Verified Organization Team Invitation
Retry 2Retry 1Initial Attempt
2% (8) 8 / 401 runs
failed over last 7 days
19.70% (79) 79 / 401 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1Initial Attempt
40% (6) 6 / 15 runs
failed over last 7 days
40% (6) 6 / 15 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 2Retry 1Initial Attempt
2.96% (12) 12 / 406 runs
failed over last 7 days
16.75% (68) 68 / 406 runs
flaked over last 7 days

📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and multiselect Question Address and multiselect text not required
Retry 1Initial Attempt
1.39% (5) 5 / 360 runs
failed over last 7 days
2.50% (9) 9 / 360 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
1.22% (5) 5 / 410 runs
failed over last 7 days
55.85% (229) 229 / 410 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-27.74% (-81) -81 / 292 runs
failed over last 7 days
93.49% (273) 273 / 292 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-38.97% (-113) -113 / 290 runs
failed over last 7 days
66.21% (192) 192 / 290 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-36.55% (-106) -106 / 290 runs
failed over last 7 days
88.62% (257) 257 / 290 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-38.62% (-112) -112 / 290 runs
failed over last 7 days
38.62% (112) 112 / 290 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-38.62% (-112) -112 / 290 runs
failed over last 7 days
38.97% (113) 113 / 290 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-38.33% (-110) -110 / 287 runs
failed over last 7 days
39.02% (112) 112 / 287 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-37.24% (-108) -108 / 290 runs
failed over last 7 days
38.62% (112) 112 / 290 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

Hey there, there is a merge conflict, can you take a look?

@github-actions github-actions bot added the 🚨 merge conflict This PR has a merge conflict that has to be addressed label Jan 28, 2024
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Feb 12, 2024
@keithwillcode keithwillcode modified the milestones: v3.8, v3.9 Feb 15, 2024
@github-actions github-actions bot removed the Stale label Feb 16, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Mar 1, 2024
@keithwillcode keithwillcode modified the milestones: v4.0, v4.1 Apr 15, 2024
@dosubot dosubot bot modified the milestone: v4.1 Apr 15, 2024
@github-actions github-actions bot removed the Stale label Apr 17, 2024
@dosubot dosubot bot modified the milestones: v4.1, v4.2 Apr 22, 2024
@dosubot dosubot bot modified the milestones: v4.1, v4.2 May 9, 2024
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label May 24, 2024
@keithwillcode keithwillcode modified the milestones: v4.2, v4.3 Jun 17, 2024
@dosubot dosubot bot removed this from the v4.3 milestone Jun 17, 2024
@keithwillcode keithwillcode added this to the v4.4 milestone Jun 17, 2024
@dosubot dosubot bot modified the milestones: v4.4, v4.5 Jul 16, 2024
@keithwillcode
Copy link
Contributor

Closing for now until we re-prio this.

@keithwillcode keithwillcode removed this from the v4.5 milestone Jul 17, 2024
@dosubot dosubot bot added this to the v4.6 milestone Sep 15, 2024
@keithwillcode keithwillcode modified the milestones: v4.6, v4.5 Sep 15, 2024
@dosubot dosubot bot modified the milestones: v4.5, v4.7 Sep 23, 2024
@dosubot dosubot bot modified the milestone: v4.8 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking consumer core area: core, team members only ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync 🚨 merge conflict This PR has a merge conflict that has to be addressed Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-1713] Ability to create one-off meetings [CAL-1713] Ability to create one-off meetings
4 participants