Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apiv2 updateNewTeamMemberEventTypes silently #17555

Merged

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Nov 8, 2024

What does this PR do?

Quick fix to avoid crashing organization team membership apiv2 endpoint when trying to update new team member event-types if one of the event-type is invalid

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Nov 8, 2024
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth event-types area: event types, event-types teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Nov 8, 2024
@graphite-app graphite-app bot requested a review from a team November 8, 2024 12:53
Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:54am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:54am

Copy link

graphite-app bot commented Nov 8, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (11/08/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

E2E results are ready!

@keithwillcode keithwillcode merged commit 82901fe into main Nov 12, 2024
41 checks passed
@keithwillcode keithwillcode deleted the fix-apiv2-update-new-team-member-event-types-silently branch November 12, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working core area: core, team members only event-types area: event types, event-types platform Anything related to our platform plan ready-for-e2e teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants