Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issues with scheduling timezone change without end time #19103

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

nayan-bagale
Copy link
Contributor

@nayan-bagale nayan-bagale commented Feb 4, 2025

What does this PR do?

Before:
Screencast from 2025-02-05 01-53-37.webm

After:
Screencast from 2025-02-05 01-57-22.webm

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Feb 4, 2025

@nayan-bagale is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2025

CLA assistant check
All committers have signed the CLA.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 4, 2025
@graphite-app graphite-app bot requested a review from a team February 4, 2025 20:56
@github-actions github-actions bot added Medium priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Feb 4, 2025
Copy link

graphite-app bot commented Feb 4, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/04/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/04/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/20/25)

1 label was added to this PR based on Keith Williams's automation.

@nayan-bagale
Copy link
Contributor Author

Hey @CarinaWolli , I’ve changed the DatePicker code and added the Calendar.tsx component to handle single-day selection. Since Calendar.tsx is now being reused, So i removed the test cases for DatePicker?

Copy link
Contributor

@TusharBhatt1 TusharBhatt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nayan-bagale can you add these changes exactly : 9ecf7be
And then let’s take this ahead

@TusharBhatt1 TusharBhatt1 mentioned this pull request Feb 20, 2025
3 tasks
@TusharBhatt1 TusharBhatt1 enabled auto-merge (squash) February 20, 2025 19:03
@TusharBhatt1 TusharBhatt1 merged commit 1be002c into calcom:main Feb 20, 2025
51 of 57 checks passed
Copy link
Contributor

E2E results are ready!

MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
…19103)

* fix: Issues with scheduling timezone change without end time

* test: remove DatePicker component tests

* feat: implement DatePicker component with tests and update button data-testid
itsalam pushed a commit to itsalam/cal.com that referenced this pull request Mar 6, 2025
…19103)

* fix: Issues with scheduling timezone change without end time

* test: remove DatePicker component tests

* feat: implement DatePicker component with tests and update button data-testid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-5127] Issues with scheduling timezone change without end time
3 participants