Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace toaster with sonner #19246

Closed

Conversation

nayan-bagale
Copy link
Contributor

@nayan-bagale nayan-bagale commented Feb 11, 2025

What does this PR do?

/claim #19238

Before:
https://github.com/user-attachments/assets/3d90fd1d-c88b-4321-8770-6bdd9478b348

After:
https://github.com/user-attachments/assets/75a2e300-7941-49fb-b198-cb70af668c2a

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Removed react-hot-toast and Added sonner to

  • /apps/web/package.json
  • /packages/lib/package.json

@nayan-bagale nayan-bagale requested a review from a team as a code owner February 11, 2025 17:32
Copy link

vercel bot commented Feb 11, 2025

@nayan-bagale is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

algora-pbc bot commented Feb 11, 2025

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@github-actions github-actions bot added ✨ feature New feature or request 💎 Bounty A bounty on Algora.io 💻 refactor 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Feb 11, 2025
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 11, 2025
@graphite-app graphite-app bot requested a review from a team February 11, 2025 17:33
@dosubot dosubot bot added the 🐛 bug Something isn't working label Feb 11, 2025
Copy link

graphite-app bot commented Feb 11, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/11/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/11/25)

1 label was added to this PR based on Keith Williams's automation.

@nayan-bagale nayan-bagale changed the title fix: replace react-hot-toast with sonner for toast notifications chore: replace toaster with sonner Feb 11, 2025
retrogtx
retrogtx previously approved these changes Feb 12, 2025
Copy link
Contributor

@retrogtx retrogtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, lgtm

PeerRich
PeerRich previously approved these changes Feb 12, 2025
Copy link

Report too large to display inline

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Known malware npm/[email protected]
  • Note: Package has been removed from the npm registry due to security concerns. This is a placeholder package published by the npm security team to prevent malicious usage of the package name. The original package likely contained harmful code.
🚫

View full report↗︎

Next steps

What is known malware?

This package is malware. We have asked the package registry to remove it.

It is strongly recommended that malware is removed from your codebase.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@retrogtx
Copy link
Contributor

hey @nayan-bagale there are some merge conflicts coming from the main branch, can you look into it? thank you

@nayan-bagale nayan-bagale dismissed stale reviews from retrogtx and PeerRich via 7cc28ae February 18, 2025 17:03
@nayan-bagale nayan-bagale requested a review from a team as a code owner February 18, 2025 17:03
@nayan-bagale nayan-bagale force-pushed the replace-toaster-with-sonner branch from 7cc28ae to 6847781 Compare February 18, 2025 17:08
@nayan-bagale
Copy link
Contributor Author

nayan-bagale commented Feb 18, 2025

Hey @retrogtx @PeerRich , Apologies for the mistake! I accidentally closed this PR, so I’ve opened a new one here: #19342. Please review it there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim 💎 Bounty A bounty on Algora.io 🐛 bug Something isn't working community Created by Linear-GitHub Sync ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI 💻 refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-5152] chore: replace toaster with sonner
3 participants